1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8302127: Remove unused arg in write_ref_field_post

Browse Source 
Reviewed-by: phh, kbarrett
This commit is contained in:
Albert Mingkun Yang 2023-02-15 14:34:30 +00:00
parent 0c9658446d
commit 28f5250fa5
6 changed files with 8 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/hotspot/share/gc/g1/g1BarrierSet.hpp
View File

@ -78,7 +78,7 @@ class G1BarrierSet: public CardTableBarrierSet {
void write_ref_array_work(MemRegion mr) { invalidate(mr); }
template <DecoratorSet decorators, typename T>
void write_ref_field_post(T* field, oop new_val);
void write_ref_field_post(T* field);
void write_ref_field_post_slow(volatile CardValue* byte);
virtual void on_thread_create(Thread* thread);

2
src/hotspot/share/gc/g1/g1BarrierSet.inline.hpp
View File

@ -68,7 +68,7 @@ inline void G1BarrierSet::write_ref_field_pre(T* field) {
}
template <DecoratorSet decorators, typename T>
inline void G1BarrierSet::write_ref_field_post(T* field, oop new_val) {
inline void G1BarrierSet::write_ref_field_post(T* field) {
volatile CardValue* byte = _card_table->byte_for(field);
if (*byte != G1CardTable::g1_young_card_val()) {
// Take a slow path for cards in old

2
src/hotspot/share/gc/shared/cardTableBarrierSet.hpp
View File

@ -80,7 +80,7 @@ protected:
// either precise or imprecise. We make non-virtual inline variants of
// these functions here for performance.
template <DecoratorSet decorators, typename T>
void write_ref_field_post(T* field, oop newVal);
void write_ref_field_post(T* field);
virtual void invalidate(MemRegion mr);

2
src/hotspot/share/gc/shared/cardTableBarrierSet.inline.hpp
View File

@ -31,7 +31,7 @@
#include "runtime/atomic.hpp"
template <DecoratorSet decorators, typename T>
inline void CardTableBarrierSet::write_ref_field_post(T* field, oop newVal) {
inline void CardTableBarrierSet::write_ref_field_post(T* field) {
volatile CardValue* byte = _card_table->byte_for(field);
*byte = CardTable::dirty_card_val();
}

2
src/hotspot/share/gc/shared/modRefBarrierSet.hpp
View File

@ -49,7 +49,7 @@ public:
inline void write_ref_field_pre(T* addr) {}
template <DecoratorSet decorators, typename T>
inline void write_ref_field_post(T *addr, oop new_value) {}
inline void write_ref_field_post(T *addr) {}
// Causes all refs in "mr" to be assumed to be modified.
virtual void invalidate(MemRegion mr) = 0;

6
src/hotspot/share/gc/shared/modRefBarrierSet.inline.hpp
View File

@ -63,7 +63,7 @@ oop_store_in_heap(T* addr, oop value) {
BarrierSetT *bs = barrier_set_cast<BarrierSetT>(barrier_set());
bs->template write_ref_field_pre<decorators>(addr);
Raw::oop_store(addr, value);
bs->template write_ref_field_post<decorators>(addr, value);
bs->template write_ref_field_post<decorators>(addr);
}
template <DecoratorSet decorators, typename BarrierSetT>
@ -74,7 +74,7 @@ oop_atomic_cmpxchg_in_heap(T* addr, oop compare_value, oop new_value) {
bs->template write_ref_field_pre<decorators>(addr);
oop result = Raw::oop_atomic_cmpxchg(addr, compare_value, new_value);
if (result == compare_value) {
bs->template write_ref_field_post<decorators>(addr, new_value);
bs->template write_ref_field_post<decorators>(addr);
}
return result;
}
@ -86,7 +86,7 @@ oop_atomic_xchg_in_heap(T* addr, oop new_value) {
BarrierSetT *bs = barrier_set_cast<BarrierSetT>(barrier_set());
bs->template write_ref_field_pre<decorators>(addr);
oop result = Raw::oop_atomic_xchg(addr, new_value);
bs->template write_ref_field_post<decorators>(addr, new_value);
bs->template write_ref_field_post<decorators>(addr);
return result;
}