1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8257398: Enhance debug output in Type::check_symmetrical

Browse Source 
Reviewed-by: vlivanov, chagedorn
This commit is contained in:
Tobias Hartmann 2020-12-01 07:02:48 +00:00
parent f48737c7b3
commit 353e791a18
1 changed files with 14 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
src/hotspot/share/opto/type.cpp
View File

@ -814,18 +814,26 @@ bool Type::interface_vs_oop(const Type *t) const {
#endif
void Type::check_symmetrical(const Type *t, const Type *mt) const {
void Type::check_symmetrical(const Type* t, const Type* mt) const {
#ifdef ASSERT
assert(mt == t->xmeet(this), "meet not commutative");
const Type* mt2 = t->xmeet(this);
if (mt != mt2) {
tty->print_cr("=== Meet Not Commutative ===");
tty->print("t = "); t->dump(); tty->cr();
tty->print("this = "); dump(); tty->cr();
tty->print("t meet this = "); mt2->dump(); tty->cr();
tty->print("this meet t = "); mt->dump(); tty->cr();
fatal("meet not commutative");
}
const Type* dual_join = mt->_dual;
const Type *t2t = dual_join->xmeet(t->_dual);
const Type *t2this = dual_join->xmeet(this->_dual);
const Type* t2t = dual_join->xmeet(t->_dual);
const Type* t2this = dual_join->xmeet(this->_dual);
// Interface meet Oop is Not Symmetric:
// Interface:AnyNull meet Oop:AnyNull == Interface:AnyNull
// Interface:NotNull meet Oop:NotNull == java/lang/Object:NotNull
if( !interface_vs_oop(t) && (t2t != t->_dual || t2this != this->_dual) ) {
if (!interface_vs_oop(t) && (t2t != t->_dual || t2this != this->_dual)) {
tty->print_cr("=== Meet Not Symmetric ===");
tty->print("t = "); t->dump(); tty->cr();
tty->print("this= "); dump(); tty->cr();
@ -838,7 +846,7 @@ void Type::check_symmetrical(const Type *t, const Type *mt) const {
tty->print("mt_dual meet t_dual= "); t2t ->dump(); tty->cr();
tty->print("mt_dual meet this_dual= "); t2this ->dump(); tty->cr();
fatal("meet not symmetric" );
fatal("meet not symmetric");
}
#endif
}