1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8300447: Parallel: Refactor PSPromotionManager::drain_stacks_depth

Browse Source 
Reviewed-by: tschatzl, kbarrett
This commit is contained in:
Albert Mingkun Yang 2023-01-19 11:51:43 +00:00
parent eba87a0ee0
commit 8f7faa631b
1 changed files with 8 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

19
src/hotspot/share/gc/parallel/psPromotionManager.cpp
View File

@ -227,7 +227,8 @@ void PSPromotionManager::restore_preserved_marks() {
}
void PSPromotionManager::drain_stacks_depth(bool totally_drain) {
totally_drain = totally_drain || (_target_stack_size == 0);
const uint threshold = totally_drain ? 0
: _target_stack_size;
PSScannerTasksQueue* const tq = claimed_stack_depth();
do {
@ -236,19 +237,15 @@ void PSPromotionManager::drain_stacks_depth(bool totally_drain) {
// Drain overflow stack first, so other threads can steal from
// claimed stack while we work.
while (tq->pop_overflow(task)) {
process_popped_location_depth(task);
if (!tq->try_push_to_taskqueue(task)) {
process_popped_location_depth(task);
}
}
if (totally_drain) {
while (tq->pop_local(task)) {
process_popped_location_depth(task);
}
} else {
while (tq->size() > _target_stack_size && tq->pop_local(task)) {
process_popped_location_depth(task);
}
while (tq->pop_local(task, threshold)) {
process_popped_location_depth(task);
}
} while ((totally_drain && !tq->taskqueue_empty()) || !tq->overflow_empty());
} while (!tq->overflow_empty());
assert(!totally_drain || tq->taskqueue_empty(), "Sanity");
assert(totally_drain || tq->size() <= _target_stack_size, "Sanity");