1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

apply review feedback and update java docs to clarify authentication retry behaviour

Browse Source
This commit is contained in:
Prateek Nima 2025-06-12 16:23:30 +01:00
parent 7a9eb0b296
commit 9e8f29ee3a
3 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/java.net.http/share/classes/jdk/internal/net/http/AuthenticationFilter.java
View File

@ -328,7 +328,7 @@ class AuthenticationFilter implements HeaderFilter {
req = HttpRequestImpl.newInstanceForAuthentication(req); req = HttpRequestImpl.newInstanceForAuthentication(req);
addBasicCredentials(req, proxy, pw, isUTF8); addBasicCredentials(req, proxy, pw, isUTF8);
return req; return req;
} else if (au.retries >= retry_limit) { } else if (au.retries > retry_limit) {
throw new IOException("too many authentication attempts. Limit: " + throw new IOException("too many authentication attempts. Limit: " +
retry_limit); retry_limit);
} else { } else {

3
src/java.net.http/share/classes/module-info.java
View File

@ -156,7 +156,8 @@
* </li> * </li>
* <li><p><b>{@systemProperty jdk.httpclient.auth.retrylimit}</b> (default: 3)<br> * <li><p><b>{@systemProperty jdk.httpclient.auth.retrylimit}</b> (default: 3)<br>
* The number of attempts the Basic authentication filter will attempt to retry a failed * The number of attempts the Basic authentication filter will attempt to retry a failed
* authentication. * authentication. The number of authentication attempts is always one greater than the
* retry limit, as the initial request does not count toward the retries.
* </li> * </li>
* <li><p><b>{@systemProperty jdk.httpclient.sendBufferSize}</b> (default: operating system * <li><p><b>{@systemProperty jdk.httpclient.sendBufferSize}</b> (default: operating system
* default)<br>The HTTP client {@linkplain java.nio.channels.SocketChannel socket} * default)<br>The HTTP client {@linkplain java.nio.channels.SocketChannel socket}

6
test/jdk/java/net/httpclient/HttpClientAuthRetryLimitTest.java
View File

@ -129,11 +129,7 @@ class HttpClientAuthRetryLimitTest implements HttpServerAdapters {
request, HttpResponse.BodyHandlers.discarding())); request, HttpResponse.BodyHandlers.discarding()));
assertEquals("too many authentication attempts. Limit: " + RETRY_LIMIT, exception.getMessage()); assertEquals("too many authentication attempts. Limit: " + RETRY_LIMIT, exception.getMessage());
int totalRequestCount = requestCount.get(); int totalRequestCount = requestCount.get();
if (RETRY_LIMIT > 0){ assertEquals(totalRequestCount, Math.max(RETRY_LIMIT, 0) + 1);
assertEquals(RETRY_LIMIT, totalRequestCount);
} else {
assertEquals(0, totalRequestCount - 1);
}
} }
} }
} }