1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8358003: KlassTrainingData initializer reads garbage holder

Browse Source 
Reviewed-by: coleenp, shade, vlivanov
This commit is contained in:
Igor Veresov 2025-06-04 14:07:49 +00:00
parent 0352477ff5
commit ae1892fb0f
1 changed files with 5 additions and 18 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/hotspot/share/oops/trainingData.cpp
View File

@ -432,24 +432,11 @@ void KlassTrainingData::print_on(outputStream* st, bool name_only) const {
} }
KlassTrainingData::KlassTrainingData(InstanceKlass* klass) : TrainingData(klass) { KlassTrainingData::KlassTrainingData(InstanceKlass* klass) : TrainingData(klass) {
if (holder() == klass) { assert(klass != nullptr, "");
return; // no change to make Handle hm(JavaThread::current(), klass->java_mirror());
} jobject hmj = JNIHandles::make_global(hm);
_holder_mirror = hmj;
jobject hmj = _holder_mirror; _holder = klass;
if (hmj != nullptr) { // clear out previous handle, if any
_holder_mirror = nullptr;
assert(JNIHandles::is_global_handle(hmj), "");
JNIHandles::destroy_global(hmj);
}
if (klass != nullptr) {
Handle hm(JavaThread::current(), klass->java_mirror());
hmj = JNIHandles::make_global(hm);
Atomic::release_store(&_holder_mirror, hmj);
}
Atomic::release_store(&_holder, const_cast<InstanceKlass*>(klass));
assert(holder() == klass, ""); assert(holder() == klass, "");
} }