1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8356751: IGV: clean up redundant field _should_send_method

Browse Source 
Co-authored-by: Manuel Hässig <mhaessig@openjdk.org>
Reviewed-by: mhaessig, thartmann, dfenacci
This commit is contained in:
Benoît Maillard 2025-06-11 11:08:38 +00:00 committed by Damon Fenacci
parent 5ae32c4c86
commit bf7d40d048
2 changed files with 6 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/hotspot/share/opto/idealGraphPrinter.cpp
View File

@ -155,7 +155,6 @@ void IdealGraphPrinter::init(const char* file_name, bool use_multiple_files, boo
// in the mach where kill projections have no users but should // in the mach where kill projections have no users but should
// appear in the dump. // appear in the dump.
_traverse_outs = true; _traverse_outs = true;
_should_send_method = true;
_output = nullptr; _output = nullptr;
buffer[0] = 0; buffer[0] = 0;
_depth = 0; _depth = 0;
@ -300,13 +299,11 @@ void IdealGraphPrinter::print_inline_tree(InlineTree *tree) {
void IdealGraphPrinter::print_inlining() { void IdealGraphPrinter::print_inlining() {
// Print inline tree // Print inline tree
if (_should_send_method) { InlineTree *inlineTree = C->ilt();
InlineTree *inlineTree = C->ilt(); if (inlineTree != nullptr) {
if (inlineTree != nullptr) { print_inline_tree(inlineTree);
print_inline_tree(inlineTree); } else {
} else { // print this method only
// print this method only
}
} }
} }
@ -382,7 +379,6 @@ void IdealGraphPrinter::begin_method() {
tail(PROPERTIES_ELEMENT); tail(PROPERTIES_ELEMENT);
_should_send_method = true;
this->_current_method = method; this->_current_method = method;
_xml->flush(); _xml->flush();
@ -975,7 +971,7 @@ void IdealGraphPrinter::print_graph(const char* name, const frame* fr) {
// Print current ideal graph // Print current ideal graph
void IdealGraphPrinter::print(const char* name, Node* node, GrowableArray<const Node*>& visible_nodes, const frame* fr) { void IdealGraphPrinter::print(const char* name, Node* node, GrowableArray<const Node*>& visible_nodes, const frame* fr) {
if (!_current_method || !_should_send_method || node == nullptr) return; if (!_current_method || node == nullptr) return;
if (name == nullptr) { if (name == nullptr) {
stringStream graph_name; stringStream graph_name;

1
src/hotspot/share/opto/idealGraphPrinter.hpp
View File

@ -110,7 +110,6 @@ class IdealGraphPrinter : public CHeapObj<mtCompiler> {
ciMethod *_current_method; ciMethod *_current_method;
int _depth; int _depth;
char buffer[2048]; char buffer[2048];
bool _should_send_method;
PhaseChaitin* _chaitin; PhaseChaitin* _chaitin;
bool _traverse_outs; bool _traverse_outs;
Compile *C; Compile *C;