1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8302975: Remove redundant mark verification during G1 Full GC

Browse Source 
Reviewed-by: ayang, kbarrett
This commit is contained in:
Thomas Schatzl 2023-02-22 15:45:12 +00:00
parent 83bea26df4
commit ee37af47cd
3 changed files with 0 additions and 20 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/hotspot/share/gc/g1/g1FullGCMarker.cpp
View File

@ -42,7 +42,6 @@ G1FullGCMarker::G1FullGCMarker(G1FullCollector* collector,
_objarray_stack(),
_preserved_stack(preserved_stack),
_mark_closure(worker_id, this, ClassLoaderData::_claim_stw_fullgc_mark, G1CollectedHeap::heap()->ref_processor_stw()),
_verify_closure(G1CollectedHeap::heap(), VerifyOption::G1UseFullMarking),
_stack_closure(this),
_cld_closure(mark_closure(), ClassLoaderData::_claim_stw_fullgc_mark),
_mark_stats_cache(mark_stats, G1RegionMarkStatsCache::RegionMarkStatsCacheSize) {

1
src/hotspot/share/gc/g1/g1FullGCMarker.hpp
View File

@ -63,7 +63,6 @@ class G1FullGCMarker : public CHeapObj<mtGC> {
// Marking closures
G1MarkAndPushClosure _mark_closure;
G1VerifyLiveClosure _verify_closure;
G1FollowStackClosure _stack_closure;
CLDToOopClosure _cld_closure;
StringDedup::Requests _string_dedup_requests;

18
src/hotspot/share/gc/g1/g1FullGCMarker.inline.hpp
View File

@ -123,14 +123,6 @@ void G1FullGCMarker::follow_array_chunk(objArrayOop array, int index) {
}
array->oop_iterate_range(mark_closure(), beg_index, end_index);
if (VerifyDuringGC) {
_verify_closure.set_containing_obj(array);
array->oop_iterate_range(&_verify_closure, beg_index, end_index);
if (_verify_closure.has_failures()) {
fatal("there should not have been any failures");
}
}
}
inline void G1FullGCMarker::follow_object(oop obj) {
@ -141,16 +133,6 @@ inline void G1FullGCMarker::follow_object(oop obj) {
follow_array((objArrayOop)obj);
} else {
obj->oop_iterate(mark_closure());
if (VerifyDuringGC) {
if (obj->is_instanceRef()) {
return;
}
_verify_closure.set_containing_obj(obj);
obj->oop_iterate(&_verify_closure);
if (_verify_closure.has_failures()) {
fatal("there should not have been any failures");
}
}
}
}