1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8288515: (ch) Unnecessary use of Math.addExact() in java.nio.channels.FileLock.overlaps()

Browse Source 
Reviewed-by: alanb
This commit is contained in:
Brian Burkhalter 2022-06-23 15:40:23 +00:00
parent 72f286a9ba
commit ef17ee4dea
1 changed files with 4 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
src/java.base/share/classes/java/nio/channels/FileLock.java
View File

@ -277,13 +277,10 @@ public abstract class FileLock implements AutoCloseable {
if (size < 0) if (size < 0)
return false; return false;
// Test whether this is below that // Test whether this is below that. The sum cannot overflow as the
try { // size and position are immutable and were checked at construction.
if (Math.addExact(this.position, this.size) <= position) if (this.position + this.size <= position) {
return false; return false;
} catch (ArithmeticException ignored) {
// the sum of this.position and this.size overflows the range of
// long hence their mathematical sum is greater than position
} }
// if size == 0 then the specified lock range is unbounded and // if size == 0 then the specified lock range is unbounded and