1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8287696: Avoid redundant Hashtable.containsKey call in JarVerifier.doneWithMeta

Browse Source 
Reviewed-by: jpai, lancea
This commit is contained in:
Andrey Turbanov 2022-06-11 10:53:35 +00:00
parent d46f404b31
commit f1143b1b57
1 changed files with 2 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/java.base/share/classes/java/util/jar/JarVerifier.java
View File

@ -199,8 +199,6 @@ class JarVerifier {
// don't compute the digest for this entry // don't compute the digest for this entry
mev.setEntry(null, je); mev.setEntry(null, je);
return;
} }
/** /**
@ -430,8 +428,8 @@ class JarVerifier {
manDig = null; manDig = null;
// MANIFEST.MF is always treated as signed and verified, // MANIFEST.MF is always treated as signed and verified,
// move its signers from sigFileSigners to verifiedSigners. // move its signers from sigFileSigners to verifiedSigners.
if (sigFileSigners.containsKey(manifestName)) { CodeSigner[] codeSigners = sigFileSigners.remove(manifestName);
CodeSigner[] codeSigners = sigFileSigners.remove(manifestName); if (codeSigners != null) {
verifiedSigners.put(manifestName, codeSigners); verifiedSigners.put(manifestName, codeSigners);
} }
} }
@ -837,7 +835,6 @@ class JarVerifier {
private List<CodeSigner[]> jarCodeSigners; private List<CodeSigner[]> jarCodeSigners;
private synchronized List<CodeSigner[]> getJarCodeSigners() { private synchronized List<CodeSigner[]> getJarCodeSigners() {
CodeSigner[] signers;
if (jarCodeSigners == null) { if (jarCodeSigners == null) {
HashSet<CodeSigner[]> set = new HashSet<>(); HashSet<CodeSigner[]> set = new HashSet<>();
set.addAll(signerMap().values()); set.addAll(signerMap().values());
@ -861,8 +858,6 @@ class JarVerifier {
} }
public CodeSource getCodeSource(URL url, JarFile jar, JarEntry je) { public CodeSource getCodeSource(URL url, JarFile jar, JarEntry je) {
CodeSigner[] signers;
return mapSignersToCodeSource(url, getCodeSigners(jar, je)); return mapSignersToCodeSource(url, getCodeSigners(jar, je));
} }