1berry/openjdk
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

8038431: Close InputStream when finished retrieving XML Signature HTTP References

Browse Source 
Reviewed-by: xuelei
This commit is contained in:
Sean Mullan 2014-04-08 11:57:57 -04:00
parent f4f394efb5
commit fa633bad05
1 changed files with 12 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

13
jdk/src/share/classes/com/sun/org/apache/xml/internal/security/utils/resolver/implementations/ResolverDirectHTTP.java
View File

@ -108,6 +108,7 @@ public class ResolverDirectHTTP extends ResourceResolverSpi {
@Override @Override
public XMLSignatureInput engineResolveURI(ResourceResolverContext context) public XMLSignatureInput engineResolveURI(ResourceResolverContext context)
throws ResourceResolverException { throws ResourceResolverException {
InputStream inputStream = null;
try { try {
// calculate new URI // calculate new URI
@ -139,7 +140,7 @@ public class ResolverDirectHTTP extends ResourceResolverSpi {
} }
String mimeType = urlConnection.getHeaderField("Content-Type"); String mimeType = urlConnection.getHeaderField("Content-Type");
InputStream inputStream = urlConnection.getInputStream(); inputStream = urlConnection.getInputStream();
ByteArrayOutputStream baos = new ByteArrayOutputStream(); ByteArrayOutputStream baos = new ByteArrayOutputStream();
byte buf[] = new byte[4096]; byte buf[] = new byte[4096];
int read = 0; int read = 0;
@ -168,6 +169,16 @@ public class ResolverDirectHTTP extends ResourceResolverSpi {
throw new ResourceResolverException("generic.EmptyMessage", ex, context.attr, context.baseUri); throw new ResourceResolverException("generic.EmptyMessage", ex, context.attr, context.baseUri);
} catch (IllegalArgumentException e) { } catch (IllegalArgumentException e) {
throw new ResourceResolverException("generic.EmptyMessage", e, context.attr, context.baseUri); throw new ResourceResolverException("generic.EmptyMessage", e, context.attr, context.baseUri);
} finally {
if (inputStream != null) {
try {
inputStream.close();
} catch (IOException e) {
if (log.isLoggable(java.util.logging.Level.FINE)) {
log.log(java.util.logging.Level.FINE, e.getMessage(), e);
}
}
}
} }
} }