15 Commits

Author SHA1 Message Date
Chris Hegarty
61940fe4ce 8241988: DatagramSocket incorrectly caches the first set of socket options
Reviewed-by: msheppar, dfuchs, alanb
2020-04-03 07:16:35 +01:00
Pavel Rappo
17ff85d4ad 8241014: Miscellaneous typos in documentation comments
Reviewed-by: igerasim, prappo, psandoz, rriggs, weijun
2020-03-20 20:54:56 +00:00
Daniel Fuchs
e0901fb627 8237896: MulticastSocket should link to DatagramChannel as an alternative for multicasting
MulticastSocket API documentation now includes some links to DatagramChannel.

Reviewed-by: alanb
2020-01-29 19:13:09 +00:00
Patrick Concannon
2f76772fa9 8236105: Behaviors of DatagramSocket/DatagramChannel::socket send methods are not always consistent
DatagramSocket and MulticastSocket changed to throw IllegalArgumentException if not connected and passed a packet containing a port out of range

Reviewed-by: chegar, dfuchs
2020-01-20 16:24:05 +00:00
Alan Bateman
d4c3278889 8236925: (dc) Upgrade DatagramChannel socket adaptor to extend MulticastSocket
Reviewed-by: dfuchs
2020-01-19 08:02:46 +00:00
Patrick Concannon
a589a15e3f 8237075: @since tag missing from DatagramSocket and MulticastSocket methods
Methods from DatagramSocket and MulticastSocket added in JDK1.2 do not have their @since tags. This fix adds them in

Reviewed-by: alanb, chegar, dfuchs
2020-01-17 12:53:31 +00:00
Daniel Fuchs
7135b5dd9c 8235141: Specify the required standard socket options for the socket types in the java.net package
Reviewed-by: alanb, chegar
2019-12-10 13:22:52 +00:00
Patrick Concannon
12e43e216e 8233191: MulticastSocket joinGroup/leaveGroup do not specify their behavior when the outgoing interface has not been set
Clarifies the behaviour of 2-arg joinGroup/leaveGroup methods when null is passed for the NetworkInteface argument. The fix also clarifies what is returned by getInterface() and getNetworkInterface() methods when no previous NetworkInterface has been set.

Reviewed-by: alanb, chegar, dfuchs
2019-12-09 15:54:44 +00:00
Julia Boes
3ea25ecdfe 8233319: Deprecate MulticastSocket methods that operate on java.net.InetAddress
Deprecate any method that operates on InetAddress as well as getLoopbackMode and setLoopbackMode

Reviewed-by: chegar, dfuchs, alanb
2019-12-09 12:06:26 +00:00
Patrick Concannon
55da7d34c9 8233307: MulticastSocket getOption(IP_MULTICAST_IF) returns interface when not set
The MulticastSocket method getOption has been changed to conform to the behavior described in StandardSocketOptions.IP_MULTICAST_IF.

Reviewed-by: chegar, dfuchs
2019-11-28 16:49:52 +00:00
Julia Boes
a8a2246158 8234335: Remove line break in class declaration in java.base
Remove line break in class declarations where applicable

Reviewed-by: rriggs, lancea
2019-11-21 09:10:21 +00:00
Daniel Fuchs
be18a54cb1 8233141: DatagramSocket.send doesn't specify exception thrown when no target address
DatagramSocket and MulticastSocket send methods are changed to throw IllegalArgumentException if no target address can be determined.

Reviewed-by: alanb
2019-11-18 16:48:05 +00:00
Julia Boes
b15b322cf3 8230648: Replace @exception tag with @throws in java.base
Minor coding style update of javadoc tag in any file in java.base

Reviewed-by: prappo, lancea
2019-09-20 11:07:52 +01:00
Arthur Eubanks
8c5313aa79 8220585: Incorrect code in MulticastSocket sample code
Sample code shows that String.length() can be passed to a DatagramPacket along with String.getBytes(), but is incorrect for non-ASCII Strings.

Reviewed-by: martin, chegar
2019-03-13 09:12:38 -07:00
Erik Joelsson
3789983e89 8187443: Forest Consolidation: Move files to unified layout
Reviewed-by: darcy, ihse
2017-09-12 19:03:39 +02:00