14 Commits

Author SHA1 Message Date
Xueming Shen
a06b63065d 8025003: Base64 should be less strict with padding
Updated spec and implementation of mime decoder to be lenient for padding

Reviewed-by: alanb
2013-10-24 11:12:59 -07:00
Roger Riggs
93dcac6266 8026982: javadoc errors in core libs
Cleanup of javadoc -Xlint errors

Reviewed-by: lancea, mduigou, darcy, mullan, mchung
2013-10-22 17:02:08 -04:00
Brian Burkhalter
1b0b4ca8c7 8020409: Clean up doclint problems in java.util package, part 1
Clean up doclint problems in java.util package, part 1

Reviewed-by: darcy
2013-07-15 14:37:01 -07:00
Lana Steuck
8f6d37ee8e Merge 2013-05-17 10:11:35 -07:00
Xueming Shen
bedabba81c 8014217: Base64.getXDecoder().wrap(...).read() doesn't throw exception for an incorrect number of padding chars in the final unit
To throw IOE for malformed final unit in base64 stream

Reviewed-by: chegar, alanb
2013-05-14 14:20:18 -07:00
David Katleman
1b186bfddd 8014289: JDK8 b89 source with GPL header errors
Reviewed-by: mchung, mduigou, tbell, dsamersoff
2013-05-09 15:04:56 -07:00
Mark Sheppard
b09026494b 8007799: Base64.getEncoder(0, byte[]) returns an encoder that unexpectedly inserts line separators
Reviewed-by: sherman, iris
2013-04-30 16:24:08 +01:00
Xueming Shen
3457ff4337 8007379: Base64.getMimeDecoder().decode() throws IAE for a non-base64 character after padding
8008925: Base64.getMimeDecoder().decode() does not ignore padding chars

Updated implementation and spec for corner cases.

Reviewed-by: alanb
2013-04-02 10:12:20 -07:00
Xueming Shen
db8ced219f 8006295: Base64.Decoder.wrap(java.io.InputStream) returns InputStream which throws unspecified IOException on attempt to decode invalid Base64 byte stream
8006315: Base64.Decoder decoding methods are not consistent in treating non-padded data
8006530: Base64.getMimeDecoder().decode() throws exception for non-base64 character after adding =

Updated the spec to describe the expected behave explicitly and the implementation to follow

Reviewed-by: alanb, chegar, lancea
2013-02-04 11:58:43 -08:00
Xueming Shen
320ce960ce 8007298: Base64.getMimeDecoder().decode() throws IAE for a single non-base64 character
8006526: Base64.Decoder.decode(String) spec contains a copy-paste mistake

To ignore single non-base64 char in mime decoding

Reviewed-by: alanb
2013-01-31 13:13:14 -08:00
Xueming Shen
907f0724ce 8005394: Base64.Decoder/Encoder.wrap(XStream) don't throw NPE for null args passed
To check null for dec/enc.wrap methods

Reviewed-by: alanb
2013-01-31 11:09:36 -08:00
Chris Hegarty
2f710eebba 8004921: Trivial javadoc warnings in Base64
Reviewed-by: darcy
2012-12-12 11:35:18 +00:00
Xueming Shen
e78a1eb083 8004212: java.util.Base64 methods decodeArray and decodeBuffer should return the number of bytes written
To return the length instead of position

Reviewed-by: alanb
2012-12-01 11:36:25 -08:00
Xueming Shen
ff1d49bc5b 8004088: hg push for bug#4235519 failed to push all files
Pushed all base64 files

Reviewed-by: alanb, mduigou
2012-11-27 22:07:11 -08:00