2022-01-28 13:29:32 -05:00
|
|
|
/*-------------------------------------------------------------------------
|
|
|
|
*
|
|
|
|
* shell_archive.c
|
|
|
|
*
|
2022-02-03 13:57:27 -05:00
|
|
|
* This archiving function uses a user-specified shell command (the
|
|
|
|
* archive_command GUC) to copy write-ahead log files. It is used as the
|
|
|
|
* default, but other modules may define their own custom archiving logic.
|
|
|
|
*
|
2023-01-02 15:00:37 -05:00
|
|
|
* Copyright (c) 2022-2023, PostgreSQL Global Development Group
|
2022-01-28 13:29:32 -05:00
|
|
|
*
|
|
|
|
* IDENTIFICATION
|
|
|
|
* src/backend/postmaster/shell_archive.c
|
|
|
|
*
|
|
|
|
*-------------------------------------------------------------------------
|
|
|
|
*/
|
|
|
|
#include "postgres.h"
|
|
|
|
|
|
|
|
#include <sys/wait.h>
|
|
|
|
|
|
|
|
#include "access/xlog.h"
|
2023-01-11 07:22:51 +01:00
|
|
|
#include "common/percentrepl.h"
|
2022-01-28 13:29:32 -05:00
|
|
|
#include "pgstat.h"
|
|
|
|
#include "postmaster/pgarch.h"
|
|
|
|
|
2022-02-03 13:57:27 -05:00
|
|
|
static bool shell_archive_configured(void);
|
|
|
|
static bool shell_archive_file(const char *file, const char *path);
|
Rework shutdown callback of archiver modules
As currently designed, with a callback registered in a ERROR_CLEANUP
block, the shutdown callback would get called twice when updating
archive_library on SIGHUP, which is something that we want to avoid to
ease the life of extension writers.
Anyway, an ERROR in the archiver process is treated as a FATAL, stopping
it immediately, hence there is no need for a ERROR_CLEANUP block.
Instead of that, the shutdown callback is not called upon
before_shmem_exit(), giving to the modules the opportunity to do any
cleanup actions before the server shuts down its subsystems.
While on it, this commit adds some testing coverage for the shutdown
callback. Neither shell_archive nor basic_archive have been using it,
and one is added to shell_archive, whose trigger is checked in a TAP
test through a shutdown sequence.
Author: Nathan Bossart, Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20221015221328.GB1821022@nathanxps13
Backpatch-through: 15
2022-10-19 14:06:56 +09:00
|
|
|
static void shell_archive_shutdown(void);
|
2022-02-03 13:57:27 -05:00
|
|
|
|
|
|
|
void
|
|
|
|
shell_archive_init(ArchiveModuleCallbacks *cb)
|
|
|
|
{
|
|
|
|
cb->check_configured_cb = shell_archive_configured;
|
|
|
|
cb->archive_file_cb = shell_archive_file;
|
Rework shutdown callback of archiver modules
As currently designed, with a callback registered in a ERROR_CLEANUP
block, the shutdown callback would get called twice when updating
archive_library on SIGHUP, which is something that we want to avoid to
ease the life of extension writers.
Anyway, an ERROR in the archiver process is treated as a FATAL, stopping
it immediately, hence there is no need for a ERROR_CLEANUP block.
Instead of that, the shutdown callback is not called upon
before_shmem_exit(), giving to the modules the opportunity to do any
cleanup actions before the server shuts down its subsystems.
While on it, this commit adds some testing coverage for the shutdown
callback. Neither shell_archive nor basic_archive have been using it,
and one is added to shell_archive, whose trigger is checked in a TAP
test through a shutdown sequence.
Author: Nathan Bossart, Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20221015221328.GB1821022@nathanxps13
Backpatch-through: 15
2022-10-19 14:06:56 +09:00
|
|
|
cb->shutdown_cb = shell_archive_shutdown;
|
2022-02-03 13:57:27 -05:00
|
|
|
}
|
|
|
|
|
|
|
|
static bool
|
|
|
|
shell_archive_configured(void)
|
|
|
|
{
|
|
|
|
return XLogArchiveCommand[0] != '\0';
|
|
|
|
}
|
|
|
|
|
|
|
|
static bool
|
2022-01-28 13:29:32 -05:00
|
|
|
shell_archive_file(const char *file, const char *path)
|
|
|
|
{
|
2023-01-11 07:22:51 +01:00
|
|
|
char *xlogarchcmd;
|
|
|
|
char *nativePath = NULL;
|
2022-01-28 13:29:32 -05:00
|
|
|
int rc;
|
|
|
|
|
2023-01-11 07:22:51 +01:00
|
|
|
if (path)
|
2022-01-28 13:29:32 -05:00
|
|
|
{
|
2023-01-11 07:22:51 +01:00
|
|
|
nativePath = pstrdup(path);
|
|
|
|
make_native_path(nativePath);
|
2022-01-28 13:29:32 -05:00
|
|
|
}
|
2023-01-11 07:22:51 +01:00
|
|
|
|
|
|
|
xlogarchcmd = replace_percent_placeholders(XLogArchiveCommand, "archive_command", "fp", file, nativePath);
|
|
|
|
|
|
|
|
if (nativePath)
|
|
|
|
pfree(nativePath);
|
2022-01-28 13:29:32 -05:00
|
|
|
|
|
|
|
ereport(DEBUG3,
|
|
|
|
(errmsg_internal("executing archive command \"%s\"",
|
|
|
|
xlogarchcmd)));
|
|
|
|
|
2022-08-29 13:55:38 -04:00
|
|
|
fflush(NULL);
|
2022-01-28 13:29:32 -05:00
|
|
|
pgstat_report_wait_start(WAIT_EVENT_ARCHIVE_COMMAND);
|
|
|
|
rc = system(xlogarchcmd);
|
|
|
|
pgstat_report_wait_end();
|
|
|
|
|
|
|
|
if (rc != 0)
|
|
|
|
{
|
|
|
|
/*
|
|
|
|
* If either the shell itself, or a called command, died on a signal,
|
|
|
|
* abort the archiver. We do this because system() ignores SIGINT and
|
|
|
|
* SIGQUIT while waiting; so a signal is very likely something that
|
|
|
|
* should have interrupted us too. Also die if the shell got a hard
|
|
|
|
* "command not found" type of error. If we overreact it's no big
|
|
|
|
* deal, the postmaster will just start the archiver again.
|
|
|
|
*/
|
|
|
|
int lev = wait_result_is_any_signal(rc, true) ? FATAL : LOG;
|
|
|
|
|
|
|
|
if (WIFEXITED(rc))
|
|
|
|
{
|
|
|
|
ereport(lev,
|
|
|
|
(errmsg("archive command failed with exit code %d",
|
|
|
|
WEXITSTATUS(rc)),
|
|
|
|
errdetail("The failed archive command was: %s",
|
|
|
|
xlogarchcmd)));
|
|
|
|
}
|
|
|
|
else if (WIFSIGNALED(rc))
|
|
|
|
{
|
|
|
|
#if defined(WIN32)
|
|
|
|
ereport(lev,
|
|
|
|
(errmsg("archive command was terminated by exception 0x%X",
|
|
|
|
WTERMSIG(rc)),
|
|
|
|
errhint("See C include file \"ntstatus.h\" for a description of the hexadecimal value."),
|
|
|
|
errdetail("The failed archive command was: %s",
|
|
|
|
xlogarchcmd)));
|
|
|
|
#else
|
|
|
|
ereport(lev,
|
|
|
|
(errmsg("archive command was terminated by signal %d: %s",
|
|
|
|
WTERMSIG(rc), pg_strsignal(WTERMSIG(rc))),
|
|
|
|
errdetail("The failed archive command was: %s",
|
|
|
|
xlogarchcmd)));
|
|
|
|
#endif
|
|
|
|
}
|
|
|
|
else
|
|
|
|
{
|
|
|
|
ereport(lev,
|
|
|
|
(errmsg("archive command exited with unrecognized status %d",
|
|
|
|
rc),
|
|
|
|
errdetail("The failed archive command was: %s",
|
|
|
|
xlogarchcmd)));
|
|
|
|
}
|
|
|
|
|
|
|
|
return false;
|
|
|
|
}
|
|
|
|
|
2023-01-11 07:22:51 +01:00
|
|
|
pfree(xlogarchcmd);
|
|
|
|
|
2022-01-28 13:29:32 -05:00
|
|
|
elog(DEBUG1, "archived write-ahead log file \"%s\"", file);
|
|
|
|
return true;
|
|
|
|
}
|
Rework shutdown callback of archiver modules
As currently designed, with a callback registered in a ERROR_CLEANUP
block, the shutdown callback would get called twice when updating
archive_library on SIGHUP, which is something that we want to avoid to
ease the life of extension writers.
Anyway, an ERROR in the archiver process is treated as a FATAL, stopping
it immediately, hence there is no need for a ERROR_CLEANUP block.
Instead of that, the shutdown callback is not called upon
before_shmem_exit(), giving to the modules the opportunity to do any
cleanup actions before the server shuts down its subsystems.
While on it, this commit adds some testing coverage for the shutdown
callback. Neither shell_archive nor basic_archive have been using it,
and one is added to shell_archive, whose trigger is checked in a TAP
test through a shutdown sequence.
Author: Nathan Bossart, Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi, Michael Paquier
Discussion: https://postgr.es/m/20221015221328.GB1821022@nathanxps13
Backpatch-through: 15
2022-10-19 14:06:56 +09:00
|
|
|
|
|
|
|
static void
|
|
|
|
shell_archive_shutdown(void)
|
|
|
|
{
|
|
|
|
elog(DEBUG1, "archiver process shutting down");
|
|
|
|
}
|