1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix missing PQclear() in libpqrcv_endstreaming().

Browse Source 
This omission leaked one PGresult per WAL streaming cycle, which possibly
would never be enough to notice in the real world, but it's still a leak.

Per Coverity.  Back-patch to 9.3 where the error was introduced.
This commit is contained in:
Tom Lane 2015-02-11 19:20:49 -05:00
parent e44735c488
commit 0ac1fedab9
1 changed files with 1 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
src/backend/replication/libpqwalreceiver/libpqwalreceiver.c
View File

@ -252,6 +252,7 @@ libpqrcv_endstreaming(TimeLineID *next_tli)
ereport(ERROR, ereport(ERROR,
(errmsg("error reading result of streaming command: %s", (errmsg("error reading result of streaming command: %s",
PQerrorMessage(streamConn)))); PQerrorMessage(streamConn))));
PQclear(res);
/* Verify that there are no more results */ /* Verify that there are no more results */
res = PQgetResult(streamConn); res = PQgetResult(streamConn);