Trivial dead code removal: in makeObjectName(), name1 must be non-NULL

(due to the preceding strlen(), for example), so we needn't recheck this
before invoking pg_mbcliplen().

Per Coverity static analysis performed by EnterpriseDB.
This commit is contained in:
Neil Conway 2005-06-21 00:35:05 +00:00
parent 638feae2c9
commit 141e878bc3

View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.131 2005/05/06 17:24:53 tgl Exp $ * $PostgreSQL: pgsql/src/backend/commands/indexcmds.c,v 1.132 2005/06/21 00:35:05 neilc Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -760,8 +760,7 @@ makeObjectName(const char *name1, const char *name2, const char *label)
name2chars--; name2chars--;
} }
if (name1) name1chars = pg_mbcliplen(name1, name1chars, name1chars);
name1chars = pg_mbcliplen(name1, name1chars, name1chars);
if (name2) if (name2)
name2chars = pg_mbcliplen(name2, name2chars, name2chars); name2chars = pg_mbcliplen(name2, name2chars, name2chars);