1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove repeated test in contrib/amcheck

Browse Source 
Repeating these tests adds unnecessary cycles, since no improvement in
test coverage is expected.

Cleanup from commit 8224de4f42ccf98e08db07b43d52fed72f962ebb.

Peter Geoghegan
This commit is contained in:
Teodor Sigaev 2018-04-09 09:19:09 +03:00
parent 9d0383c015
commit 1671c01650
2 changed files with 2 additions and 24 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

20
contrib/amcheck/expected/check_btree.out
View File

@ -111,27 +111,9 @@ SELECT bt_index_parent_check('bttest_multi_idx', true);
(1 row) (1 row)
SELECT bt_index_parent_check('bttest_multi_idx', true); -- repeat expansive test for index built using insertions
bt_index_parent_check
-----------------------
(1 row)
-- repeat same checks with index made by insertions
TRUNCATE bttest_multi; TRUNCATE bttest_multi;
INSERT INTO bttest_multi SELECT i, i%2 FROM generate_series(1, 100000) as i; INSERT INTO bttest_multi SELECT i, i%2 FROM generate_series(1, 100000) as i;
SELECT bt_index_check('bttest_multi_idx');
bt_index_check
----------------
(1 row)
SELECT bt_index_parent_check('bttest_multi_idx', true);
bt_index_parent_check
-----------------------
(1 row)
SELECT bt_index_parent_check('bttest_multi_idx', true); SELECT bt_index_parent_check('bttest_multi_idx', true);
bt_index_parent_check bt_index_parent_check
----------------------- -----------------------

6
contrib/amcheck/sql/check_btree.sql
View File

@ -65,15 +65,11 @@ COMMIT;
SELECT bt_index_check('bttest_multi_idx'); SELECT bt_index_check('bttest_multi_idx');
-- more expansive test for index with included columns -- more expansive test for index with included columns
SELECT bt_index_parent_check('bttest_multi_idx', true); SELECT bt_index_parent_check('bttest_multi_idx', true);
SELECT bt_index_parent_check('bttest_multi_idx', true);
-- repeat same checks with index made by insertions -- repeat expansive test for index built using insertions
TRUNCATE bttest_multi; TRUNCATE bttest_multi;
INSERT INTO bttest_multi SELECT i, i%2 FROM generate_series(1, 100000) as i; INSERT INTO bttest_multi SELECT i, i%2 FROM generate_series(1, 100000) as i;
SELECT bt_index_check('bttest_multi_idx');
SELECT bt_index_parent_check('bttest_multi_idx', true); SELECT bt_index_parent_check('bttest_multi_idx', true);
SELECT bt_index_parent_check('bttest_multi_idx', true);
-- cleanup -- cleanup
DROP TABLE bttest_a; DROP TABLE bttest_a;