1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix temporary memory leak in system table index scans

Browse Source 
Commit 811af9786b introduced palloc() calls into systable_beginscan()
and systable_beginscan_ordered().  But there was no pfree(), as is the
usual style.

It turns out that an ANALYZE of a partitioned table can invoke many
thousand system table index scans, and this memory is not cleaned up
until the end of the command, so this can temporarily leak quite a bit
of memory.  Maybe there are improvements to be made at a higher level
about this, but for now, insert a couple of corresponding pfree()
calls to fix this particular issue.

Reported-by: Justin Pryzby <pryzby@telsasoft.com>
Discussion: https://www.postgresql.org/message-id/Z0XTfIq5xUtbkiIh@pryzbyj2023
This commit is contained in:
Peter Eisentraut 2024-12-03 09:04:20 +01:00
parent 1ba0782ce9
commit 1acf10549e
1 changed files with 4 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/backend/access/index/genam.c
View File

@ -449,6 +449,8 @@ systable_beginscan(Relation heapRelation,
snapshot, nkeys, 0); snapshot, nkeys, 0);
index_rescan(sysscan->iscan, idxkey, nkeys, NULL, 0); index_rescan(sysscan->iscan, idxkey, nkeys, NULL, 0);
sysscan->scan = NULL; sysscan->scan = NULL;
pfree(idxkey);
} }
else else
{ {
@ -713,6 +715,8 @@ systable_beginscan_ordered(Relation heapRelation,
index_rescan(sysscan->iscan, idxkey, nkeys, NULL, 0); index_rescan(sysscan->iscan, idxkey, nkeys, NULL, 0);
sysscan->scan = NULL; sysscan->scan = NULL;
pfree(idxkey);
/* /*
* If CheckXidAlive is set then set a flag to indicate that system table * If CheckXidAlive is set then set a flag to indicate that system table
* scan is in-progress. See detailed comments in xact.c where these * scan is in-progress. See detailed comments in xact.c where these