1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Make GIN's cleanup pending list process interruptable

Browse Source 
Cleanup process could be called by ordinary insert/update and could take a lot
of time. Add vacuum_delay_point() to make this process interruptable. Under
vacuum this call will also throttle a vacuum process to decrease system load,
called from insert/update it will not throttle, and that reduces a latency.

Backpatch for all supported branches.

Jeff Janes <jeff.janes@gmail.com>
This commit is contained in:
Teodor Sigaev 2015-09-07 17:18:45 +03:00
parent e3fa55d143
commit 364c023570
1 changed files with 3 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/backend/access/gin/ginfast.c
View File

@ -800,8 +800,7 @@ ginInsertCleanup(GinState *ginstate,
*/ */
processPendingPage(&accum, &datums, page, FirstOffsetNumber); processPendingPage(&accum, &datums, page, FirstOffsetNumber);
if (vac_delay) vacuum_delay_point();
vacuum_delay_point();
/* /*
* Is it time to flush memory to disk? Flush if we are at the end of * Is it time to flush memory to disk? Flush if we are at the end of
@ -841,8 +840,7 @@ ginInsertCleanup(GinState *ginstate,
{ {
ginEntryInsert(ginstate, attnum, key, category, ginEntryInsert(ginstate, attnum, key, category,
list, nlist, NULL); list, nlist, NULL);
if (vac_delay) vacuum_delay_point();
vacuum_delay_point();
} }
/* /*
@ -922,7 +920,7 @@ ginInsertCleanup(GinState *ginstate,
/* /*
* Read next page in pending list * Read next page in pending list
*/ */
CHECK_FOR_INTERRUPTS(); vacuum_delay_point();
buffer = ReadBuffer(index, blkno); buffer = ReadBuffer(index, blkno);
LockBuffer(buffer, GIN_SHARE); LockBuffer(buffer, GIN_SHARE);
page = BufferGetPage(buffer); page = BufferGetPage(buffer);