1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid need for valgrind suppressions for pg_atomic_init_u64 on some platforms.

Browse Source 
Previously we used pg_atomic_write_64_impl inside
pg_atomic_init_u64. That works correctly, but on platforms without
64bit single copy atomicity it could trigger spurious valgrind errors
about uninitialized memory, because we use compare_and_swap for atomic
writes on such platforms.

I previously suppressed one instance of this problem (6c878edc1df),
but as Tom reports that wasn't enough. As the atomic variable cannot
yet be concurrently accessible during initialization, it seems better
to have pg_atomic_init_64_impl set the value directly.

Change pg_atomic_init_u32_impl for symmetry.

Reported-By: Tom Lane
Author: Andres Freund
Discussion: https://postgr.es/m/1714601.1591503815@sss.pgh.pa.us
Backpatch: 9.5-
This commit is contained in:
Andres Freund 2020-06-08 19:52:19 -07:00
parent 09dc174863
commit 3801532918
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/include/port/atomics/generic.h
View File

@ -162,7 +162,7 @@ pg_atomic_clear_flag_impl(volatile pg_atomic_flag *ptr)
static inline void
pg_atomic_init_u32_impl(volatile pg_atomic_uint32 *ptr, uint32 val_)
{
pg_atomic_write_u32_impl(ptr, val_);
ptr->value = val_;
}
#endif
@ -312,7 +312,7 @@ pg_atomic_read_u64_impl(volatile pg_atomic_uint64 *ptr)
static inline void
pg_atomic_init_u64_impl(volatile pg_atomic_uint64 *ptr, uint64 val_)
{
pg_atomic_write_u64_impl(ptr, val_);
ptr->value = val_;
}
#endif