1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bug in original implementation of xmlserialize(): if user specifies

Browse Source 
a target type that isn't acceptable, the code failed to raise the proper
error.  The result instead was to return a NULL expression tree, which
in a quick test led to a 'cache lookup failed for type 0' error later.

Patch 8.3 only --- I fixed this in HEAD as part of recent locations patch.
This commit is contained in:
Tom Lane 2008-08-29 17:27:50 +00:00
parent a9ff5f0722
commit 3c3fb2160c
1 changed files with 12 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
src/backend/parser/parse_expr.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $PostgreSQL: pgsql/src/backend/parser/parse_expr.c,v 1.226 2008/01/01 19:45:50 momjian Exp $ * $PostgreSQL: pgsql/src/backend/parser/parse_expr.c,v 1.226.2.1 2008/08/29 17:27:50 tgl Exp $
* *
*------------------------------------------------------------------------- *-------------------------------------------------------------------------
*/ */
@ -1539,9 +1539,10 @@ transformXmlExpr(ParseState *pstate, XmlExpr *x)
static Node * static Node *
transformXmlSerialize(ParseState *pstate, XmlSerialize *xs) transformXmlSerialize(ParseState *pstate, XmlSerialize *xs)
{ {
Node *result;
XmlExpr *xexpr;
Oid targetType; Oid targetType;
int32 targetTypmod; int32 targetTypmod;
XmlExpr *xexpr;
xexpr = makeNode(XmlExpr); xexpr = makeNode(XmlExpr);
xexpr->op = IS_XMLSERIALIZE; xexpr->op = IS_XMLSERIALIZE;
@ -1563,8 +1564,15 @@ transformXmlSerialize(ParseState *pstate, XmlSerialize *xs)
* from text. This way, user-defined text-like data types automatically * from text. This way, user-defined text-like data types automatically
* fit in. * fit in.
*/ */
return (Node *) coerce_to_target_type(pstate, (Node *) xexpr, TEXTOID, targetType, targetTypmod, result = coerce_to_target_type(pstate, (Node *) xexpr,
COERCION_IMPLICIT, COERCE_IMPLICIT_CAST); TEXTOID, targetType, targetTypmod,
COERCION_IMPLICIT, COERCE_IMPLICIT_CAST);
if (result == NULL)
ereport(ERROR,
(errcode(ERRCODE_CANNOT_COERCE),
errmsg("cannot cast XMLSERIALIZE result to %s",
format_type_be(targetType))));
return result;
} }
static Node * static Node *