1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pgbench: Remove dead code

Browse Source 
doConnect() never returns connections in state CONNECTION_BAD, so
checking for that is pointless.  Remove the code that does.

This code has been dead since ba708ea3dc84, 20 years ago.

Discussion: https://postgr.es/m/20210126195224.GA20361@alvherre.pgsql
Reviewed-by: Tom Lane <tgl@sss.pgh.pa.us>
This commit is contained in:
Alvaro Herrera 2021-01-28 12:50:40 -03:00
parent bcae842b96
commit 4162f91d1c
No known key found for this signature in database
GPG Key ID: 1C20ACB9D5C564AE
1 changed files with 0 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
src/bin/pgbench/pgbench.c
View File

@ -3911,14 +3911,6 @@ main(int argc, char **argv)
if (con == NULL)
exit(1);
if (PQstatus(con) == CONNECTION_BAD)
{
fprintf(stderr, "connection to database \"%s\" failed\n",
PQdb(con) ? PQdb(con) : "");
fprintf(stderr, "%s", PQerrorMessage(con));
exit(1);
}
if (internal_script_used)
{
/*