1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Simplify version check for SKIP clause

Browse Source 
Checking for the required versions of IO::Pty as well as IPC::Run
can be achieved with a single eval call, and by using the VERSION
function the comparison is guaranteed to follow the same rules as
calling 'use' on the module with a version.

Reported-by: Andrew Dunstan <andrew@dunslane.net>
Discussion: https://postgr.es/m/6d880ea2-f8ca-f458-4dcd-a7a3e6d6cd7c@dunslane.net
This commit is contained in:
Daniel Gustafsson 2023-04-08 23:32:11 +02:00
parent 980e8879f5
commit 6ff2e8cdd4
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/test/authentication/t/001_password.pl
View File

@ -107,7 +107,7 @@ is($res, 'SCRAM-SHA-256$1024:', 'scram_iterations in server side ROLE');
SKIP:
{
skip "IO::Pty and IPC::Run >= 0.98 required", 1 unless
(eval { require IO::Pty; } && eval { $IPC::Run::VERSION >= '0.98' });
eval { require IO::Pty; IPC::Run->VERSION('0.98'); };
# Alter the password on the created role using \password in psql to ensure
# that clientside password changes use the scram_iterations value when