1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

pg_restore: Fix wrong descriptions of --with-{schema,data,statistics} options.

Browse Source 
Commit bde2fb797aa added the --with-schema, --with-data, and --with-statistics
options to pg_restore. These options control whether to restore schema, data,
or statistics if present in the archive. However, the help message and
documentation incorrectly described them as affecting what gets dumped.

This commit corrects those descriptions to clarify that the options control
restoration, not dumping.

Bug: #18952
Reported-by: TAKATSUKA Haruka <harukat@sraoss.co.jp>
Author: Fujii Masao <masao.fujii@gmail.com>
Reviewed-by: TAKATSUKA Haruka <harukat@sraoss.co.jp>
Reviewed-by: Daniel Gustafsson <daniel@yesql.se>
Discussion: https://postgr.es/m/18952-be40a620f8b1e755@postgresql.org
This commit is contained in:
Fujii Masao 2025-06-12 23:25:21 +09:00
parent 0f65f3eec4
commit 84914e964b
2 changed files with 9 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
doc/src/sgml/ref/pg_restore.sgml
View File

@ -923,7 +923,8 @@ PostgreSQL documentation
<term><option>--with-data</option></term> <term><option>--with-data</option></term>
<listitem> <listitem>
<para> <para>
Dump data. This is the default. Output commands to restore data, if the archive contains them.
This is the default.
</para> </para>
</listitem> </listitem>
</varlistentry> </varlistentry>
@ -932,7 +933,8 @@ PostgreSQL documentation
<term><option>--with-schema</option></term> <term><option>--with-schema</option></term>
<listitem> <listitem>
<para> <para>
Dump schema (data definitions). This is the default. Output commands to restore schema (data definitions), if the archive
contains them. This is the default.
</para> </para>
</listitem> </listitem>
</varlistentry> </varlistentry>
@ -941,7 +943,8 @@ PostgreSQL documentation
<term><option>--with-statistics</option></term> <term><option>--with-statistics</option></term>
<listitem> <listitem>
<para> <para>
Dump statistics. This is the default. Output commands to restore statistics, if the archive contains them.
This is the default.
</para> </para>
</listitem> </listitem>
</varlistentry> </varlistentry>

6
src/bin/pg_dump/pg_restore.c
View File

@ -712,9 +712,9 @@ usage(const char *progname)
printf(_(" --use-set-session-authorization\n" printf(_(" --use-set-session-authorization\n"
" use SET SESSION AUTHORIZATION commands instead of\n" " use SET SESSION AUTHORIZATION commands instead of\n"
" ALTER OWNER commands to set ownership\n")); " ALTER OWNER commands to set ownership\n"));
printf(_(" --with-data dump the data\n")); printf(_(" --with-data restore the data\n"));
printf(_(" --with-schema dump the schema\n")); printf(_(" --with-schema restore the schema\n"));
printf(_(" --with-statistics dump the statistics\n")); printf(_(" --with-statistics restore the statistics\n"));
printf(_("\nConnection options:\n")); printf(_("\nConnection options:\n"));
printf(_(" -h, --host=HOSTNAME database server host or socket directory\n")); printf(_(" -h, --host=HOSTNAME database server host or socket directory\n"));