1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix bogus logic for skipping unnecessary partcollation dependencies.

Browse Source 
The idea here is to not call recordDependencyOn for the default collation,
since we know that's pinned.  But what the code actually did was to record
the partition key's dependency on the opclass twice, instead.

Evidently introduced by sloppy coding in commit 2186b608b.  Back-patch
to v10 where that came in.
This commit is contained in:
Tom Lane 2018-12-13 15:11:09 -05:00
parent a0696d2955
commit 8b90174e3f
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/catalog/heap.c
View File

@ -3145,7 +3145,7 @@ StorePartitionKey(Relation rel,
/* Mark this relation as dependent on a few things as follows */ /* Mark this relation as dependent on a few things as follows */
myself.classId = RelationRelationId; myself.classId = RelationRelationId;
myself.objectId = RelationGetRelid(rel);; myself.objectId = RelationGetRelid(rel);
myself.objectSubId = 0; myself.objectSubId = 0;
/* Operator class and collation per key column */ /* Operator class and collation per key column */
@ -3164,9 +3164,9 @@ StorePartitionKey(Relation rel,
referenced.classId = CollationRelationId; referenced.classId = CollationRelationId;
referenced.objectId = partcollation[i]; referenced.objectId = partcollation[i];
referenced.objectSubId = 0; referenced.objectSubId = 0;
}
recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL); recordDependencyOn(&myself, &referenced, DEPENDENCY_NORMAL);
}
} }
/* /*