1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

In the final emptying phase of the new GiST buffering build, set the

Browse Source 
queuedForEmptying flag correctly on buffer when adding it to the queue.
Also, don't add buffer to the queue if it's there already. These were
harmless oversights; failing to set the flag just means that a buffer might
get added to the queue twice if more tuples are added to it (although that
can't actually happen at this point because all the upper buffers have
already been emptied), and having the same buffer twice in the emptying
queue is harmless. But better be tidy.
This commit is contained in:
Heikki Linnakangas 2011-09-12 13:00:44 +03:00
parent b0025bd957
commit 8caf6132c7
1 changed files with 8 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/access/gist/gistbuild.c
View File

@ -964,10 +964,14 @@ gistEmptyAllBuffers(GISTBuildState *buildstate)
* Add this buffer to the emptying queue, and proceed to empty
* the queue.
*/
MemoryContextSwitchTo(gfbb->context);
gfbb->bufferEmptyingQueue =
lcons(nodeBuffer, gfbb->bufferEmptyingQueue);
MemoryContextSwitchTo(buildstate->tmpCtx);
if (!nodeBuffer->queuedForEmptying)
{
MemoryContextSwitchTo(gfbb->context);
nodeBuffer->queuedForEmptying = true;
gfbb->bufferEmptyingQueue =
lcons(nodeBuffer, gfbb->bufferEmptyingQueue);
MemoryContextSwitchTo(buildstate->tmpCtx);
}
gistProcessEmptyingQueue(buildstate);
}
else