1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Remove a couple of unnecessary if-tests.

Browse Source 
Commit abd9ca377 replaced a couple of while-loops in fmtfloat()
with calls to dopr_outchmulti, but I (tgl) failed to notice that
the new if-tests guarding those calls were really unnecessary,
because they're inside a larger if-block checking the same thing.

Ranier Vilela

Discussion: https://postgr.es/m/MN2PR18MB2927850AB00CF39CC370D107E34B0@MN2PR18MB2927.namprd18.prod.outlook.com
This commit is contained in:
Tom Lane 2019-11-24 12:03:16 -05:00
parent 45ff049e28
commit 91da65f4ac
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/port/snprintf.c
View File

@ -1227,16 +1227,14 @@ fmtfloat(double value, char type, int forcesign, int leftjust,
{ {
/* pad before exponent */ /* pad before exponent */
dostr(convert, epos - convert, target); dostr(convert, epos - convert, target);
if (zeropadlen > 0) dopr_outchmulti('0', zeropadlen, target);
dopr_outchmulti('0', zeropadlen, target);
dostr(epos, vallen - (epos - convert), target); dostr(epos, vallen - (epos - convert), target);
} }
else else
{ {
/* no exponent, pad after the digits */ /* no exponent, pad after the digits */
dostr(convert, vallen, target); dostr(convert, vallen, target);
if (zeropadlen > 0) dopr_outchmulti('0', zeropadlen, target);
dopr_outchmulti('0', zeropadlen, target);
} }
} }
else else