1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "Add temporary debug logging, in 9.4 branch only."

Browse Source 
This reverts commit e55380f3b60108d402f64131fe655b0e5ccc1f31.
It's served its purpose.
This commit is contained in:
Tom Lane 2018-04-18 11:57:37 -04:00
parent 248c268d5b
commit 92b503c48d
3 changed files with 0 additions and 22 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/commands/indexcmds.c
View File

@ -758,8 +758,6 @@ DefineIndex(Oid relationId,
*/ */
validate_index(relationId, indexRelationId, snapshot); validate_index(relationId, indexRelationId, snapshot);
PrintSnapMgrStatus("concurrent index build, before snapshot release");
/* /*
* Drop the reference snapshot. We must do this before waiting out other * Drop the reference snapshot. We must do this before waiting out other
* snapshot holders, else we will deadlock against other processes also * snapshot holders, else we will deadlock against other processes also
@ -772,13 +770,9 @@ DefineIndex(Oid relationId,
limitXmin = snapshot->xmin; limitXmin = snapshot->xmin;
PopActiveSnapshot(); PopActiveSnapshot();
PrintSnapMgrStatus("concurrent index build, after PopActiveSnapshot");
UnregisterSnapshot(snapshot); UnregisterSnapshot(snapshot);
PrintSnapMgrStatus("concurrent index build, after UnregisterSnapshot");
InvalidateCatalogSnapshot(); InvalidateCatalogSnapshot();
PrintSnapMgrStatus("concurrent index build, after InvalidateCatalogSnapshot");
/* /*
* The index is now valid in the sense that it contains all currently * The index is now valid in the sense that it contains all currently
* interesting tuples. But since it might not contain tuples deleted just * interesting tuples. But since it might not contain tuples deleted just

14
src/backend/utils/time/snapmgr.c
View File

@ -1401,17 +1401,3 @@ HistoricSnapshotGetTupleCids(void)
Assert(HistoricSnapshotActive()); Assert(HistoricSnapshotActive());
return tuplecid_data; return tuplecid_data;
} }
void
PrintSnapMgrStatus(const char *context)
{
int asdepth = 0;
ActiveSnapshotElt *active;
for (active = ActiveSnapshot; active != NULL; active = active->as_next)
asdepth++;
elog(LOG, "%s: %d reg snaps, %d active snaps, cat snap %p, xmin %u",
context, RegisteredSnapshots, asdepth,
CatalogSnapshot, MyPgXact->xmin);
}

2
src/include/utils/snapmgr.h
View File

@ -65,6 +65,4 @@ extern void SetupHistoricSnapshot(Snapshot snapshot_now, struct HTAB *tuplecids)
extern void TeardownHistoricSnapshot(bool is_error); extern void TeardownHistoricSnapshot(bool is_error);
extern bool HistoricSnapshotActive(void); extern bool HistoricSnapshotActive(void);
extern void PrintSnapMgrStatus(const char *context);
#endif /* SNAPMGR_H */ #endif /* SNAPMGR_H */