1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Declare mkdtemp() only if we're providing it.

Browse Source 
Follow our usual style of providing an "extern" for a standard library
function only when we're also providing the implementation.  This avoids
issues when the system headers declare the function slightly differently
than we do, as noted by Caleb Welton.

We might have to go to the extent of probing to see if the system headers
declare the function, but let's not do that until it's demonstrated to be
necessary.

Oversight in commit 9e6b1bf258170e62dac555fc82ff0536dfe01d29.  Back-patch
to all supported branches, as that was.
This commit is contained in:
Tom Lane 2014-10-17 22:55:36 -04:00
parent 31021e7ba3
commit 98170fa465
1 changed files with 4 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/include/port.h
View File

@ -403,6 +403,10 @@ extern int getopt(int nargc, char *const * nargv, const char *ostr);
extern int isinf(double x); extern int isinf(double x);
#endif #endif
#ifndef HAVE_MKDTEMP
extern char *mkdtemp(char *path);
#endif
#ifndef HAVE_RINT #ifndef HAVE_RINT
extern double rint(double x); extern double rint(double x);
#endif #endif
@ -464,7 +468,4 @@ extern void qsort_arg(void *base, size_t nel, size_t elsize,
/* port/chklocale.c */ /* port/chklocale.c */
extern int pg_get_encoding_from_locale(const char *ctype); extern int pg_get_encoding_from_locale(const char *ctype);
/* port/mkdtemp.c */
extern char *mkdtemp(char *path);
#endif /* PG_PORT_H */ #endif /* PG_PORT_H */