1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix two small bugs in json's populate_record_worker

Browse Source 
The first bug is not releasing a tupdesc when doing an early return out
of the function. The second bug is a logic error in choosing when to do
an early return if given an empty jsonb object.

Bug reports from Pavel Stehule and Tom Lane respectively.

Backpatch to 9.4 where these were introduced.
This commit is contained in:
Andrew Dunstan 2015-05-04 12:38:58 -04:00
parent 79edb29812
commit 997066f445
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/utils/adt/jsonfuncs.c
View File

@ -2099,6 +2099,7 @@ populate_record_worker(FunctionCallInfo fcinfo, const char *funcname,
if (hash_get_num_entries(json_hash) == 0 && rec)
{
hash_destroy(json_hash);
ReleaseTupleDesc(tupdesc);
PG_RETURN_POINTER(rec);
}
}
@ -2107,9 +2108,12 @@ populate_record_worker(FunctionCallInfo fcinfo, const char *funcname,
jb = PG_GETARG_JSONB(json_arg_num);
/* same logic as for json */
if (!have_record_arg && rec)
if (JB_ROOT_COUNT(jb) == 0 && rec)
{
ReleaseTupleDesc(tupdesc);
PG_RETURN_POINTER(rec);
}
}
ncolumns = tupdesc->natts;