1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

simplify_function() mustn't try to evaluate functions that return

Browse Source 
composite types, because TupleTableSlots aren't Datums and can't be
stored in Const nodes.  We can remove this restriction if we ever
adopt a cleaner runtime representation for whole-tuple results, but
at the moment it's broken.  Per example from Thomas Hallgren.
This commit is contained in:
Tom Lane 2004-01-28 00:05:25 +00:00
parent 03ef7ebafa
commit 9f017115f5
1 changed files with 11 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
src/backend/optimizer/util/clauses.c
View File

@ -8,7 +8,7 @@
* *
* *
* IDENTIFICATION * IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.154.2.1 2003/12/09 01:56:41 tgl Exp $ * $Header: /cvsroot/pgsql/src/backend/optimizer/util/clauses.c,v 1.154.2.2 2004/01/28 00:05:25 tgl Exp $
* *
* HISTORY * HISTORY
* AUTHOR DATE MAJOR EVENT * AUTHOR DATE MAJOR EVENT
@ -1655,6 +1655,7 @@ evaluate_function(Oid funcid, Oid result_type, List *args,
bool has_null_input = false; bool has_null_input = false;
List *arg; List *arg;
FuncExpr *newexpr; FuncExpr *newexpr;
char result_typtype;
/* /*
* Can't simplify if it returns a set. * Can't simplify if it returns a set.
@ -1691,6 +1692,15 @@ evaluate_function(Oid funcid, Oid result_type, List *args,
has_nonconst_input) has_nonconst_input)
return NULL; return NULL;
/*
* Can't simplify functions returning composite types (mainly because
* datumCopy() doesn't cope; FIXME someday when we have a saner
* representation for whole-tuple results).
*/
result_typtype = get_typtype(funcform->prorettype);
if (result_typtype == 'c')
return NULL;
/* /*
* OK, looks like we can simplify this operator/function. * OK, looks like we can simplify this operator/function.
* *