1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Add missing pstrdup calls

Browse Source 
The one for the OCLASS_COLLATION case was noticed by
CLOBBER_CACHE_ALWAYS buildfarm members; the others I spotted by manual
code inspection.

Also remove a redundant check.
This commit is contained in:
Alvaro Herrera 2014-12-31 13:19:40 -03:00
parent c168c88577
commit ba66c9d068
1 changed files with 5 additions and 10 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

15
src/backend/catalog/objectaddress.c
View File

@ -1513,12 +1513,6 @@ pg_get_object_address(PG_FUNCTION_ARGS)
*/ */
switch (type) switch (type)
{ {
case OBJECT_LARGEOBJECT:
if (list_length(name) != 1)
ereport(ERROR,
(errcode(ERRCODE_INVALID_PARAMETER_VALUE),
errmsg("name list length must be exactly %d", 1)));
break;
case OBJECT_DOMCONSTRAINT: case OBJECT_DOMCONSTRAINT:
case OBJECT_OPCLASS: case OBJECT_OPCLASS:
case OBJECT_OPFAMILY: case OBJECT_OPFAMILY:
@ -3370,7 +3364,8 @@ getObjectIdentityParts(const ObjectAddress *object,
quote_qualified_identifier(schema, quote_qualified_identifier(schema,
NameStr(coll->collname))); NameStr(coll->collname)));
if (objname) if (objname)
*objname = list_make2(schema, NameStr(coll->collname)); *objname = list_make2(schema,
pstrdup(NameStr(coll->collname)));
ReleaseSysCache(collTup); ReleaseSysCache(collTup);
break; break;
} }
@ -3667,7 +3662,7 @@ getObjectIdentityParts(const ObjectAddress *object,
quote_identifier(NameStr(rule->rulename))); quote_identifier(NameStr(rule->rulename)));
getRelationIdentity(&buffer, rule->ev_class, objname); getRelationIdentity(&buffer, rule->ev_class, objname);
if (objname) if (objname)
*objname = lappend(*objname, NameStr(rule->rulename)); *objname = lappend(*objname, pstrdup(NameStr(rule->rulename)));
heap_close(ruleDesc, AccessShareLock); heap_close(ruleDesc, AccessShareLock);
break; break;
@ -3693,7 +3688,7 @@ getObjectIdentityParts(const ObjectAddress *object,
quote_identifier(NameStr(trig->tgname))); quote_identifier(NameStr(trig->tgname)));
getRelationIdentity(&buffer, trig->tgrelid, objname); getRelationIdentity(&buffer, trig->tgrelid, objname);
if (objname) if (objname)
*objname = lappend(*objname, NameStr(trig->tgname)); *objname = lappend(*objname, pstrdup(NameStr(trig->tgname)));
heap_close(trigDesc, AccessShareLock); heap_close(trigDesc, AccessShareLock);
break; break;
@ -3719,7 +3714,7 @@ getObjectIdentityParts(const ObjectAddress *object,
quote_identifier(NameStr(policy->polname))); quote_identifier(NameStr(policy->polname)));
getRelationIdentity(&buffer, policy->polrelid, objname); getRelationIdentity(&buffer, policy->polrelid, objname);
if (objname) if (objname)
*objname = lappend(*objname, NameStr(policy->polname)); *objname = lappend(*objname, pstrdup(NameStr(policy->polname)));
heap_close(polDesc, AccessShareLock); heap_close(polDesc, AccessShareLock);
break; break;