1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Avoid low-probability crash on out-of-memory.

Browse Source 
check_restrict_nonsystem_relation_kind() correctly uses guc_malloc()
in v16 and later.  But in older branches it must use malloc()
directly, and it forgot to check for failure return.
Faulty backpatching of 66e94448a.

Karina Litskevich

Discussion: https://postgr.es/m/CACiT8iZ=atkguKVbpN4HmJFMb4+T9yEowF5JuPZG8W+kkZ9L6w@mail.gmail.com
This commit is contained in:
Tom Lane 2024-12-05 12:54:41 -05:00
parent 1168acbca4
commit cd1c8b992e
1 changed files with 5 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
src/backend/tcop/postgres.c
View File

@ -3489,6 +3489,11 @@ check_restrict_nonsystem_relation_kind(char **newval, void **extra, GucSource so
/* Save the flags in *extra, for use by the assign function */ /* Save the flags in *extra, for use by the assign function */
*extra = malloc(sizeof(int)); *extra = malloc(sizeof(int));
if (*extra == NULL)
ereport(ERROR,
(errcode(ERRCODE_OUT_OF_MEMORY),
errmsg("out of memory")));
*((int *) *extra) = flags; *((int *) *extra) = flags;
return true; return true;