1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Repair longstanding error in btree xlog replay: XLogReadBuffer should be

Browse Source 
passed extend = true whenever we are reading a page we intend to reinitialize
completely, even if we think the page "should exist".  This is because it
might indeed not exist, if the relation got truncated sometime after the
current xlog record was made and before the crash we're trying to recover
from.  These two thinkos appear to explain both of the old bug reports
discussed here:
http://archives.postgresql.org/pgsql-hackers/2005-05/msg01369.php
This commit is contained in:
Tom Lane 2006-03-28 21:17:58 +00:00
parent ac2c2a457f
commit e243ba23d3
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/backend/access/nbtree/nbtxlog.c
View File

@ -8,7 +8,7 @@
* Portions Copyright (c) 1994, Regents of the University of California
*
* IDENTIFICATION
* $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtxlog.c,v 1.7 2003/09/29 23:40:26 tgl Exp $
* $Header: /cvsroot/pgsql/src/backend/access/nbtree/nbtxlog.c,v 1.7.2.1 2006/03/28 21:17:58 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -251,7 +251,7 @@ btree_xlog_split(bool redo, bool onleft, bool isroot,
rightsib = (onleft) ? xlrec->otherblk : targetblk;
/* Left (original) sibling */
buffer = XLogReadBuffer(false, reln, leftsib);
buffer = XLogReadBuffer(true, reln, leftsib);
if (!BufferIsValid(buffer))
elog(PANIC, "btree_split_%s: lost left sibling", op);
@ -524,7 +524,7 @@ btree_xlog_delete_page(bool redo, bool ismeta,
}
/* Rewrite target page as empty deleted page */
buffer = XLogReadBuffer(false, reln, target);
buffer = XLogReadBuffer(true, reln, target);
if (!BufferIsValid(buffer))
elog(PANIC, "btree_delete_page_%s: lost target page", op);
page = (Page) BufferGetPage(buffer);