1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Don't run recover crash_temp_files test in Windows perl

Browse Source 
This reverts commit 677271a3a125e294b33b891669f594a2c8cb36ce.
"Unbreak recovery test on Windows"

The test hangs on Windows, and attempts to remedy the problem have
proved fragile at best. So we simply disable the test on Windows perl.
(Msys perl seems perfectly happy).

Discussion: https://postgr.es/m/5b748470-7335-5439-e876-6a88c951e1c5@dunslane.net
This commit is contained in:
Andrew Dunstan 2021-03-21 15:04:45 -04:00
parent 2b526ed2e1
commit ef82387384
1 changed files with 11 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

18
src/test/recovery/t/022_crash_temp_files.pl
View File

@ -6,7 +6,15 @@ use TestLib;
use Test::More;
use Config;
plan tests => 9;
if ($Config{osname} eq 'MSWin32')
{
plan skip_all => 'tests hang on Windows';
exit;
}
else
{
plan tests => 9;
}
# To avoid hanging while expecting some specific input from a psql
@ -124,10 +132,8 @@ $killme_stderr2 = '';
my $ret = TestLib::system_log('pg_ctl', 'kill', 'KILL', $pid);
is($ret, 0, 'killed process with KILL');
# Explicitly shut down psql gracefully - to avoid hangs or worse on windows
$killme_stdin .= "\\q\n";
# Close psql session
$killme->finish;
$killme_stdin2 .= "\\q\n";
$killme2->finish;
# Wait till server restarts
@ -214,10 +220,8 @@ $killme_stderr2 = '';
$ret = TestLib::system_log('pg_ctl', 'kill', 'KILL', $pid);
is($ret, 0, 'killed process with KILL');
# Explicitly shut down psql gracefully - to avoid hangs or worse on windows
$killme_stdin .= "\\q\n";
# Close psql session
$killme->finish;
$killme_stdin2 .= "\\q\n";
$killme2->finish;
# Wait till server restarts