1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Keep exec_simple_check_plan() from thinking "SELECT foo INTO bar" is simple.

Browse Source 
It's not clear if this situation can occur in plpgsql other than via the
EXECUTE USING case Heikki illustrated, which I will shortly close off.
However, ignoring the intoClause if it's there is surely wrong, so let's
patch it for safety.

Backpatch to 8.3, which is as far back as this code has a PlannedStmt
to deal with.  There might be another way to make an equivalent test
before that, but since this is just preventing hypothetical bugs,
I'm not going to obsess about it.
This commit is contained in:
Tom Lane 2010-08-19 18:10:56 +00:00
parent 3d7feba4b3
commit f5c496b7f5
1 changed files with 3 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/pl/plpgsql/src/pl_exec.c
View File

@ -8,7 +8,7 @@
*
*
* IDENTIFICATION
* $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.261.2.3 2010/08/19 17:31:50 tgl Exp $
* $PostgreSQL: pgsql/src/pl/plpgsql/src/pl_exec.c,v 1.261.2.4 2010/08/19 18:10:56 tgl Exp $
*
*-------------------------------------------------------------------------
*/
@ -5272,6 +5272,8 @@ exec_simple_check_plan(PLpgSQL_expr *expr)
*/
if (!IsA(stmt, PlannedStmt))
return;
if (stmt->commandType != CMD_SELECT || stmt->intoClause)
return;
plan = stmt->planTree;
if (!IsA(plan, Result))
return;