1berry/postgres
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Fix parallel amvacuumcleanup safety bug.

Browse Source 
Commit b4af70cb inverted the return value of the function
parallel_processing_is_safe(), but missed the amvacuumcleanup test.
Index AMs that don't support parallel cleanup at all were affected.

The practical consequences of this bug were not very serious.  Hash
indexes are affected, but since they just return the number of blocks
during hashvacuumcleanup anyway, it can't have had much impact.

Author: Masahiko Sawada <sawada.mshk@gmail.com>
Discussion: https://postgr.es/m/CAD21AoA-Em+aeVPmBbL_s1V-ghsJQSxYL-i3JP8nTfPiD1wjKw@mail.gmail.com
Backpatch: 14-, where commit b4af70cb appears.
This commit is contained in:
Peter Geoghegan 2021-11-02 19:52:10 -07:00
parent 61a86ed55b
commit f6162c020c
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/backend/access/heap/vacuumlazy.c
View File

@ -4120,7 +4120,7 @@ parallel_processing_is_safe(Relation indrel, LVShared *lvshared)
/* Skip, if the index does not support parallel cleanup */ /* Skip, if the index does not support parallel cleanup */
if (((vacoptions & VACUUM_OPTION_PARALLEL_CLEANUP) == 0) && if (((vacoptions & VACUUM_OPTION_PARALLEL_CLEANUP) == 0) &&
((vacoptions & VACUUM_OPTION_PARALLEL_COND_CLEANUP) == 0)) ((vacoptions & VACUUM_OPTION_PARALLEL_COND_CLEANUP) == 0))
return true; return false;
/* /*
* Skip, if the index supports parallel cleanup conditionally, but we * Skip, if the index supports parallel cleanup conditionally, but we