21684 Commits

Author SHA1 Message Date
Tom Lane
49d0ac4472 Fix core dump in error path of plpgsql_parse_tripwordtype. Somebody
introduced a copy-and-pasteo while trying to simplify the code.
2005-12-09 17:09:00 +00:00
Bruce Momjian
832bcfef55 I reconfirmed MS-VC6. Thank you for wonderful correspondence.
However, Another problem newly occurred.
This solves the problem of snprintf and vsnprintf.

Patch to HEAD and 8.1.X.

Hiroshi Saito
2005-12-09 04:50:50 +00:00
Bruce Momjian
df56447077 Release note wording improvements. 2005-12-08 23:22:38 +00:00
Bruce Momjian
d4fa3a8c78 Wrap UTF-8 paragraph. 2005-12-08 22:45:51 +00:00
Bruce Momjian
9f389f7db9 Update wording of translation bug item. 2005-12-08 22:36:52 +00:00
Bruce Momjian
96a1732710 Stamp 8.1.1. 2005-12-08 22:31:10 +00:00
Bruce Momjian
4bafc1202a Update release notes for 8.1.1. 2005-12-08 22:22:27 +00:00
Bruce Momjian
5e6e9526c9 Update 8.1.X FAQs. 2005-12-08 21:37:54 +00:00
Bruce Momjian
e2d7e03fb2 FAQ_AIX in 8.1.0 contains outdated information about how to deal with
postgres problems due to readline.  The attached patch replaces that
section of it with better ways of handling the problem.

Seneca Cunningham
2005-12-08 21:36:55 +00:00
Bruce Momjian
6c8e20ad1b there's a paragraph in the ALTER TABLE reference page that reads:
DROP CONSTRAINT

    This form drops constraints on a table. Currently, constraints on tables
    are not required to have unique names, so there may be more than one
    constraint matching the specified name. All matching constraints will be
    dropped.

To my knowledge, it is no longer possible to create constraints with the
same name for the same relation. When you create a constraint and specify
the same name explictly, an error is raised. Implicit constraint creation
won't choose an existing name either and up to now you could not rename a
constraint. Renaming works with the patch I sent in a few hours ago but this
patch as well won't allow constraints with identical names on the same
relation.

The attached patch thus removes the note in the docs.

Joachim Wieland
2005-12-08 21:35:41 +00:00
Bruce Momjian
8c52b34bc7 Remove empty heading row in error table. 2005-12-08 21:23:13 +00:00
Peter Eisentraut
061fecc50b Add missing translation marker 2005-12-08 21:17:46 +00:00
Bruce Momjian
6ae578d261 Add "Constant" column to error code table.
Also, better mark section headings.

kdio@uenf.br
2005-12-08 21:01:55 +00:00
Peter Eisentraut
ff4cc77bca Documentation fix: s/event_object_name/event_object_table/g 2005-12-08 20:46:54 +00:00
Tom Lane
bafe47497a Fix bgwriter's failure to release buffer pins and open files after an
error.  This probably explains bug #2099 and could also account for
mysterious VACUUM hangups.
2005-12-08 19:19:31 +00:00
Bruce Momjian
7f155c3322 I recently received the Debian bug report below about missing iconv
support for the dbf2pg contrib module.

The submitter created a patch which replaces the silent ignoring of -F
(when iconv support is disabled) with a meaningful warning.

Martin Pitt
2005-12-08 18:04:38 +00:00
Bruce Momjian
00b013b56e Add documentation about the inability of plpsql to use parameter names
that are the same as column names used in the function.
2005-12-08 18:02:10 +00:00
Bruce Momjian
a3e1e99674 Disble some Win32-specific code in win32-client-only builds:
I have the problem, when building by MS-VC6.
An error occurs in the 8.1.0 present source codes.

nmake -f win32.mak
..\..\port\getaddrinfo.c(244) : error C2065: 'WSA_NOT_ENOUGH_MEMORY'
..\..\port\getaddrinfo.c(342) : error C2065: 'WSATYPE_NOT_FOUND'

This is used by winsock2.h. However, Construction of a windows base is
winsock.h.
Then, Since MinGW has special environment, this is right. but, it is not
found in VC6.
Furthermore, in getaddrinfo.c, IPV6-API is used by
LoadLibraryA("ws2_32");
Referring to of dll the external memory generates this violation by VC6
specification.

I considered whether the whole should have been converted into winsock2.
However, Now, DLL of MinGW creation operates wonderfully as it is.
That's right, it has pliability by replacement of simple DLL.
Then, I propose the system using winsock(non IPV6) in construction of
VC6.

Hiroshi Saito
2005-12-08 17:52:20 +00:00
Tom Lane
5ca6ab404d Fix incorrect SPI example, per Yoshihisa Nakano. 2005-12-07 15:39:32 +00:00
Bruce Momjian
95f1f192e8 Improve lazy vacuum wording. 2005-12-07 14:36:08 +00:00
Bruce Momjian
5db90cc645 Clarify vacuum lazy can shrink a file under certain circumstances. 2005-12-07 05:36:08 +00:00
Bruce Momjian
c90f02316e Update iconv wording, per Peter. 2005-12-06 21:01:32 +00:00
Bruce Momjian
494d1f1497 Highlight diff idea for iconv. 2005-12-06 20:26:02 +00:00
Bruce Momjian
34dc4228cb iconv uses UTF-8, not UTF8. 2005-12-06 20:19:38 +00:00
Bruce Momjian
ead868059b Document method of removing invalid UTF8 escape sequences from dump
file.  Backpatch to 8.1.X.

Paul Lindner
2005-12-06 19:27:09 +00:00
Bruce Momjian
0ebd65ddd4 Since my name has a non-ascii-letter in it, it's often spelled wrong. In
the latest release notes there is a latin1 character that shouldn't be
there so I made a patch to fix that. This patch also fixes some old
entries that uses o instead of ö (which is also wrong but not as
bad as including a latin1 character in the sgml file).

Dennis Bj?rklund
2005-12-06 18:43:40 +00:00
Bruce Momjian
42860677a4 Add documentation on the use of *printf() macros and libintl.
Backpatch to 8.1.X.
2005-12-06 18:35:36 +00:00
Teodor Sigaev
3482b4597e Fix stupid bug with sizeof 2005-12-06 18:22:27 +00:00
Tom Lane
386f0e50ef In a nestloop inner indexscan, it's OK to use pushed-down baserestrictinfo
clauses even if it's an outer join.  This is a corner case since such
clauses could only arise from weird OUTER JOIN ON conditions, but worth
fixing.  Per example from Ron at cheapcomplexdevices.com.
2005-12-06 16:50:46 +00:00
Tom Lane
edae280e69 ecpg/pgtypeslib seems to need snprintf.c pulled in, too. 2005-12-06 05:26:30 +00:00
Tom Lane
24bc418969 Put undef's before extern declarations that need 'em, per Andrew Dunstan. 2005-12-06 05:13:56 +00:00
Bruce Momjian
4d870d5d8a Add comment on why pg *printf functions are used unconditionally on
Win32.

Backpatch to 8.1.X.
2005-12-06 04:53:28 +00:00
Tom Lane
f244c488fb Make Win32 build use our port/snprintf.c routines, instead of depending
on libintl which may or may not provide what we need.  Make a few marginal
cleanups to ensure this works.  Andrew Dunstan and Tom Lane.
2005-12-06 02:29:27 +00:00
Tom Lane
dc68b9ec30 Add regression test to see if the min/max values of int8 convert correctly. 2005-12-05 04:13:53 +00:00
Tom Lane
fcda95d987 Fix a rather sizable number of problems in our homegrown snprintf, such as
incorrect implementation of argument reordering, arbitrary limit of output
size for sprintf and fprintf, willingness to access more bytes than "%.Ns"
specification allows, wrong formatting of LONGLONG_MIN, various field-padding
bugs and omissions.  I believe it now accurately implements a subset of
the Single Unix Spec requirements (remaining unimplemented features are
documented, too).  Bruce Momjian and Tom Lane.
2005-12-05 02:39:43 +00:00
Tatsuo Ishii
3824460544 Two fixes from Tom Lan. See the posting "[PATCHES] A couple of
proposed pgbench changes" on 2005/11/29 for more details.

The change at line 490 updates doCustom's local variable "commands"
after selecting a new file (command sequence).  I think that the
existing coding will cause the thing to use the first command of the
old sequence in the remainder of the routine, which would be a bug.
I have not tried to set up a test case to prove it, though.

The other two changes cause doCustom to loop after processing a
meta-command.  This might be a bit controversial, but as the code
is currently written, each meta-command "costs" one cycle of the
outer select() loop.  Thus, for example, with the default TPC-B script,
once a backend returns "COMMIT" it will not receive a new command
until four cycles of issuing commands to other backends have elapsed.
(You can see this very easily by strace'ing pgbench under load.)
2005-12-04 01:22:42 +00:00
Tom Lane
a9bdac055c Fix out-of-order inclusion of -L switches from LDFLAGS on AIX and HPUX.
Per example from Dirk Pirschel.
2005-12-03 20:16:39 +00:00
Bruce Momjian
dfdec60447 Allow to_char(interval) and to_char(time) to use AM/PM specifications.
Map them to a single day, so '30 hours' is 'AM'.

Have to_char(interval) and to_char(time) use "HH", "HH12" as 12-hour
intervals, rather than bypass and print the full interval hours.  This
is neeeded because to_char(time) is mapped to interval in this function.
Intervals should use "HH24", and document suggestion.

Allow "D" format specifiers for interval/time.
2005-12-03 16:45:23 +00:00
Tom Lane
4ed2e803ef Fix obsolete description of -h option, per Andreas Schmidt. 2005-12-02 23:13:53 +00:00
Michael Meskes
43a10d3a16 Added special handling of CONNECTION variable that is used by ECPG instead of given to the backend.
I failed to notice that CONNECTION had become a keyword in 8.1.
2005-12-02 15:04:48 +00:00
Tom Lane
2913b95308 Rearrange code in ExecInitBitmapHeapScan so that we don't initialize the
child plan nodes until we have acquired lock on the relation to scan.
The relative order of initialization of plan nodes isn't real important in
other cases, but it's critical here because one is supposed to lock a
relation before its indexes, not vice versa.  The original coding was at
least vulnerable to deadlock against DROP INDEX, and perhaps worse things.
2005-12-02 01:30:26 +00:00
Tom Lane
3ece85f8bf Retry in FileRead and FileWrite if Windows returns ERROR_NO_SYSTEM_RESOURCES.
Also add a retry for Unixen returning EINTR, which hasn't been reported
as an issue but at least theoretically could be.  Patch by Qingqing Zhou,
some minor adjustments by me.
2005-12-01 20:24:31 +00:00
Tom Lane
963a811a67 Check for overflow in strtol() while parsing datetime inputs.
Michael Fuhr.
2005-12-01 17:56:43 +00:00
Neil Conway
bc0b56c0fe Fix typo in PL/PgSQL documentation, per Chris KL. 2005-12-01 10:38:09 +00:00
Tom Lane
29ebf0df81 Rearrange code in pg_atoi() to avoid assuming that isspace() cannot
change errno.  No reported bugs here, but why take a chance?
2005-11-30 23:10:16 +00:00
Tom Lane
2883fbb808 Tweak choose_bitmap_and() heuristics in the light of example provided in bug
#2075: consider an index redundant if any of its index conditions were already
used, rather than if all of them were.  Also, make the selectivity comparison
a bit fuzzy, so that very small differences in estimated selectivities don't
skew the results.
2005-11-30 17:10:25 +00:00
Michael Meskes
dd13bf167b - Made several variables "const char *" instead of "char *" as proposed by Qingqing Zhou <zhouqq@cs.toronto.edu>.
- Replaced all strdup() calls by ECPGstrdup().
2005-11-30 12:50:37 +00:00
Tom Lane
c4279b45fd Tweak hash join code to use an additional heuristic for deciding whether
it's worth probing the outer relation for emptiness before building the
hash table.  To wit, if we're rescanning a join previously performed,
remember whether we found it nonempty the previous time, and don't bother
with the probe if it was nonempty.  This buys back the performance lost
in examples like Mario Weilguni's.
2005-11-28 23:46:25 +00:00
Bruce Momjian
fc9b777a79 Improve documentation for COALESCE and NULLIF. Add references for NVL
and IFNULL.

Backpatch to 8.1.X.
2005-11-28 23:19:03 +00:00
Alvaro Herrera
8f105ad65c Install a more future-proof fix for the snapshot-unset bug just found.
Per suggestion from Tom Lane.
2005-11-28 17:23:12 +00:00