35903 Commits

Author SHA1 Message Date
akr
4565cd66ed Close FDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 15:03:34 +00:00
akr
69105a1724 Close FDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46260 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 14:50:42 +00:00
akr
60cb6f6eaa Close sockets.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46259 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 14:28:44 +00:00
akr
bf6c098d04 Close pipes.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46258 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 14:17:46 +00:00
akr
9a51bc62f9 Use the block form of Open3.popen3 to close FDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46257 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 14:06:39 +00:00
akr
ab4c6921cb Join threads.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 13:48:06 +00:00
akr
5b75a0614f Join threads, not kill.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46255 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 13:28:39 +00:00
akr
e6da7c5ca9 test/io/console/test_io_console.rb: Close FDs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46254 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 12:51:49 +00:00
akr
6f226d9d42 * lib/webrick/server.rb: Use a pipe to detect server shutdown.
shutdown() or close() for listening socket is not a reliable.
  Actually, both doesn't work (doesn't wake up select()) on
  DragonFly BSD 3.6.2.

* test/webrick/utils.rb: :ShutdownSocketWithoutClose is not required
  now to immediate server shutdown detection.
  This fixes fd leaks.

* test/net/http/utils.rb: Ditto.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46253 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 12:32:48 +00:00
akr
99e389a6a7 svn:ignore property added.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 12:03:40 +00:00
akr
283e5d5aab * test/lib/minitest/unit.rb (check_fd_leak): Sort the inspected
objects list for a FD.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 12:01:09 +00:00
akr
e03e2b95a0 * test/lib/minitest/unit.rb (check_fd_leak): Try GC to delete leaked
FDs.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 09:08:23 +00:00
naruse
d4101d636f force_encoding to get the log of failure by Encoding::CompatibilityError
https://travis-ci.org/ruby/ruby/jobs/26361118

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46249 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 08:52:58 +00:00
nobu
bb1fb1167e minitest/unit.rb: defer requiring -test-
* test/lib/minitest/unit.rb (find_fds): defer requiring a library
  under "-test-" until needed, or can't work in other (installed)
  ruby.  grep doesn't need separated map.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46248 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 06:27:23 +00:00
nobu
5cc1d57c39 fileno.c: suppress warnings
* ext/-test-/dir/fileno.c (dir_check): suppress unused-function
  warnings, used only when dirfd() is available.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46247 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 03:18:08 +00:00
nobu
279aaaf9a4 printf.c: suppress warnings
* ext/-test-/printf/printf.c (printf_test_call): suppress
  maybe-uninitialized warnings.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46246 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 03:18:07 +00:00
naruse
0dea3e1a43 * test/lib/test/unit/parallel.rb (_run_suite): orig_stdout may be nil
though I don't know the reason.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46245 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 03:06:47 +00:00
nobu
b901b87543 test_string.rb: move and add assertions
* test/ruby/test_string.rb (test_slice): move the assertion for
  [Bug #9882], and more assertion for `ascii_only?` too, as
  pointed out by Heesob Park in [ruby-core:62846].

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46244 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 02:55:26 +00:00
nobu
950508e9b7 string.c: reset code range
* string.c (rb_str_substr): need to reset code range for shared
  string too, not only copied string.
  [ruby-core:62842] [Bug #9882]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46243 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 02:33:38 +00:00
nobu
361978beb2 test_beginendblock.rb: avoid leaking threads
* test/ruby/test_beginendblock.rb (test_endblock_raise): not only
  kill, but also wait the end.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46242 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 02:32:37 +00:00
nobu
4e741f4b89 erb.rb: ERB#result does not accept a proc.
* lib/erb.rb (result): [DOC] no longer accepts a Proc, as
  Kernel.eval does not.  [fix GH-619]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46241 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-30 01:22:23 +00:00
akr
83ead3c4a7 * ext/-test-/dir: Dir#fileno implemented.
* test/lib/minitest/unit.rb (find_fds): Don't return the fd used to
  scan /proc/$$/fd.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46240 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 22:28:47 +00:00
normal
fae18c95be remove empty rb_gc_mark_parser function
* parse.y (rb_gc_mark_parser): remove, empty since r8758
* internal.h: ditto, not usable from extensions since 2.0.0
* gc.c (gc_mark_roots): remove checkpoint for parser

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46239 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 19:49:22 +00:00
svn
d2684fd18e * 2014-05-30
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46238 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 15:45:29 +00:00
usa
6c42f57177 * vm_trace.c, vm.c, thread.c: get rid of (maybe false positive) warnings about
using uninitialized var with VC++.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46237 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 15:45:25 +00:00
akr
ce0c2b2170 test/test_syslog.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46235 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 14:59:24 +00:00
akr
1a956cea38 test/readline/test_readline.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46234 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 14:47:28 +00:00
nobu
fad56622f7 signal.c: return proper member
* signal.c (ruby_signal): should return either `old.sa_sigaction`
  or `old.sa_handler`, depending on whether `SA_SIGINFO` is set in
  `old.sa_flags`, because they may not be a union.
  [ruby-core:62836] [Bug #9878]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46233 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 14:27:53 +00:00
akr
52e91e0f72 * io.c (pipe_open): Close pipes when rb_execarg_fixup() raises
an exception.
  (rb_execarg_fixup_v): New function.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46232 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 14:13:20 +00:00
akr
6f39cf2d1e test/test_pty.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46231 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 13:38:39 +00:00
akr
b519ce9a8a * test/lib/minitest/unit.rb (capture_subprocess_io): Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46230 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 13:26:02 +00:00
akr
2edc9ea5f8 test/logger/test_logdevice.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46229 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 13:12:38 +00:00
akr
a2f9b00ad4 test/io/nonblock/test_flush.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46228 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 12:42:14 +00:00
akr
a1afdfeb06 test/fileutils/test_fileutils.rb: Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46227 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 12:07:39 +00:00
akr
be4d1fd953 * io.c (rb_io_s_pipe): Close pipes if io_encoding_set() raises an
exception.
  (io_encoding_set_v): New function.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46225 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 11:29:47 +00:00
akr
2ad2007307 * lib/csv.rb (CSV.open): Close the opened file when an exception occur.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46224 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 10:44:59 +00:00
akr
68ac33a511 * ext/openssl/lib/openssl/ssl.rb (SSLServer#accept): Close a socket
if any exception occur. 



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46223 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 10:32:19 +00:00
nobu
c65ef1539b configure.in: fix messages
* configure.in (RUBY_FUNC_ATTRIBUTE): show the attribute name in
  the message if the macro name is not given.  fix up r45608.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46222 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-29 00:58:21 +00:00
nobu
88789fdeed localeinit.c: revert r46202
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46221 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 23:35:43 +00:00
akr
4bf480b7d5 Suppress warnings.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46220 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 22:59:07 +00:00
normal
205e690646 include/ruby/ruby.h: hide Symbol internals
This is too new to be a compatibility problem.

* include/ruby/ruby.h: Hide Symbol internals.
  (struct RSymbol): moved to internal.h
  (RSYMBOL): ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46219 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 20:08:56 +00:00
akr
eb9f446ebf * ext/socket/unixsocket.c (rsock_init_unixsock): Open a socket
after path length check.
  This fixes a fd leak by TestSocket_UNIXSocket#test_too_long_path.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46218 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 15:42:09 +00:00
svn
b73eaef7a8 * 2014-05-29
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46217 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 15:06:43 +00:00
akr
971df741b9 Close fds.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46216 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 15:06:39 +00:00
akr
a7b1cfbb99 * test/ruby/test_io.rb (test_flush_in_finalizer1): Use
ObjectSpace.each_object to close files.
  GC.start is not reliable.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46212 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 14:06:28 +00:00
akr
58a6412754 No need to kill a thread.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46211 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 11:17:48 +00:00
akr
cbd370f669 * lib/net/imap.rb (Net::IMAP#initialize): Close the opened socket when
any exception occur.
  This fixes a fd leak by IMAPTest#test_imaps_post_connection_check
  which start_tls_session() raises an exception.




git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46210 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 10:02:54 +00:00
akr
02afafb42a * ext/openssl/ossl_ssl.c (ossl_ssl_close): Fix sync_close to work
when SSL is not started.
  This fix the fd leak by test_https_proxy_authentication in
  test/net/http/test_https_proxy.rb.



git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46209 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 09:09:26 +00:00
nobu
73cf9abd1c drbtest.rb: avoid leaking threads
* test/drb/drbtest.rb (test_06_timeout): clean up worker threads
  to avoid leaking threads.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46208 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 08:03:55 +00:00
nobu
ca2c5ded93 test/rake: avoid leaking threads
* test/rake/test_rake_task.rb (teardown): clean up thread pool to
  avoid leaking threads.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@46207 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2014-05-28 06:22:09 +00:00