1berry/solidus
1
0
Fork 0
Code Issues Pull Requests Actions Packages Projects Releases Wiki Activity

Remove unutilized coffee-rails dependency

Browse Source 
All coffee script has been translated into vanilla javascript and no
longer requires the gem coffee-rails. This PR removes the dependency
and all associated language associated with utilization of the gem.
This commit is contained in:
Connor Ferguson 2022-06-06 06:47:08 -06:00
parent 4cc1d5aeb0
commit a4a571c52b
9 changed files with 7 additions and 14 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
.editorconfig
View File

@ -15,7 +15,7 @@ tab_width = 2
[**.rb] [**.rb]
max_line_length = 80 max_line_length = 80
[**.js, **.coffee] [**.js]
max_line_length = 120 max_line_length = 120
[*.md] [*.md]

7
backend/README.md
View File

@ -8,12 +8,7 @@ Backend contains the controllers, views, and assets making up the admin interfac
Can be found in [app/assets/javascripts/spree/backend/](./app/assets/javascripts/spree/backend/) Can be found in [app/assets/javascripts/spree/backend/](./app/assets/javascripts/spree/backend/)
Our scripts are written in a mix of CoffeeScript and JavaScript (ES5). We can't Any new files should be in JavaScript (ES5).
easily use a transpiler for ECMAScript >= 6 without adding additional steps for
applications using solidus\_admin.
Though we have existing CoffeeScript files, any new files should be in
JavaScript (ES5).
### Stylesheets ### Stylesheets

1
backend/lib/spree/backend.rb
View File

@ -4,7 +4,6 @@ require 'spree_core'
require 'spree_api' require 'spree_api'
require 'jquery-rails' require 'jquery-rails'
require 'coffee-rails'
require 'sassc-rails' require 'sassc-rails'
require 'handlebars_assets' require 'handlebars_assets'
require 'font-awesome-rails' require 'font-awesome-rails'

1
backend/solidus_backend.gemspec
View File

@ -26,7 +26,6 @@ Gem::Specification.new do |s|
s.add_dependency 'solidus_api', s.version s.add_dependency 'solidus_api', s.version
s.add_dependency 'solidus_core', s.version s.add_dependency 'solidus_core', s.version
s.add_dependency 'coffee-rails'
s.add_dependency 'font-awesome-rails', '~> 4.0' s.add_dependency 'font-awesome-rails', '~> 4.0'
s.add_dependency 'jbuilder', '~> 2.8' s.add_dependency 'jbuilder', '~> 2.8'
s.add_dependency 'jquery-rails' s.add_dependency 'jquery-rails'

2
backend/spec/teaspoon_env.rb
View File

@ -31,7 +31,7 @@ if defined?(DummyApp)
config.suite do |suite| config.suite do |suite|
suite.use_framework :mocha, "2.3.3" suite.use_framework :mocha, "2.3.3"
suite.matcher = "{spec/javascripts,app/assets}/**/*_spec.{js,js.coffee,coffee}" suite.matcher = "{spec/javascripts,app/assets}/**/*_spec.js"
suite.helper = "spec_helper" suite.helper = "spec_helper"
suite.boot_partial = "/boot" suite.boot_partial = "/boot"
suite.expand_assets = true suite.expand_assets = true

2
core/lib/generators/solidus/install/templates/vendor/assets/javascripts/spree/backend/all.js vendored
View File

@ -1,5 +1,5 @@
// This is a manifest file that'll be compiled into including all the files listed below. // This is a manifest file that'll be compiled into including all the files listed below.
// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically // Add new JavaScript code in separate files in this directory and they'll automatically
// be included in the compiled file accessible from http://example.com/assets/application.js // be included in the compiled file accessible from http://example.com/assets/application.js
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the // It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
// the compiled file. // the compiled file.

2
core/lib/generators/solidus/install/templates/vendor/assets/javascripts/spree/frontend/all.js vendored
View File

@ -1,5 +1,5 @@
// This is a manifest file that'll be compiled into including all the files listed below. // This is a manifest file that'll be compiled into including all the files listed below.
// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically // Add new JavaScript code in separate files in this directory and they'll automatically
// be included in the compiled file accessible from http://example.com/assets/application.js // be included in the compiled file accessible from http://example.com/assets/application.js
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the // It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
// the compiled file. // the compiled file.

2
core/lib/spree/testing_support/dummy_app/assets/javascripts/spree/backend/all.js
View File

@ -1,5 +1,5 @@
// This is a manifest file that'll be compiled into including all the files listed below. // This is a manifest file that'll be compiled into including all the files listed below.
// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically // Add new JavaScript code in separate files in this directory and they'll automatically
// be included in the compiled file accessible from http://example.com/assets/application.js // be included in the compiled file accessible from http://example.com/assets/application.js
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the // It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
// the compiled file. // the compiled file.

2
core/lib/spree/testing_support/dummy_app/assets/javascripts/spree/frontend/all.js
View File

@ -1,5 +1,5 @@
// This is a manifest file that'll be compiled into including all the files listed below. // This is a manifest file that'll be compiled into including all the files listed below.
// Add new JavaScript/Coffee code in separate files in this directory and they'll automatically // Add new JavaScript code in separate files in this directory and they'll automatically
// be included in the compiled file accessible from http://example.com/assets/application.js // be included in the compiled file accessible from http://example.com/assets/application.js
// It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the // It's not advisable to add code directly here, but if you do, it'll appear at the bottom of the
// the compiled file. // the compiled file.