1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Revert "benchmark: fix broken fs.cpSync benchmark"

Browse Source 
This reverts commit 52430b9839c31f846a788125efda82887d115e21.

PR-URL: https://github.com/nodejs/node/pull/58476
Fixes: https://github.com/nodejs/node/issues/58468
Reviewed-By: Dario Piotrowicz <dario.piotrowicz@gmail.com>
This commit is contained in:
Yuesong Jake Li 2025-05-28 09:27:34 +09:30 committed by Node.js GitHub Bot
parent 0c6e16bc84
commit 49679ddd98
1 changed files with 1 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
benchmark/fs/bench-cpSync.js
View File

@ -8,10 +8,7 @@ const tmpdir = require('../../test/common/tmpdir');
const bench = common.createBenchmark(main, { const bench = common.createBenchmark(main, {
n: [1, 100, 10_000], n: [1, 100, 10_000],
dereference: ['true', 'false'], dereference: ['true', 'false'],
// When `force` is `true` the `cpSync` function is called twice the second force: ['true', 'false'],
// time however an `ERR_FS_CP_EINVAL` is thrown, so skip `true` for the time being
// TODO: allow `force` to also be `true` once https://github.com/nodejs/node/issues/58468 is addressed
force: ['false'],
}); });
function prepareTestDirectory() { function prepareTestDirectory() {