1berry/nodejs
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
40,021 Commits 59 Branches 887 Tags
Commit Graph

40021 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Vinícius Lourenço
adaef03216 perf_hooks: reduce overhead of createHistogram 
PR-URL: https://github.com/nodejs/node/pull/50074
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-10-23 12:38:54 +00:00
Robert Nagy
8e814e3b82
stream: avoid getter for defaultEncoding 
PR-URL: https://github.com/nodejs/node/pull/50203
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-23 12:08:26 +00:00
Lucas Santos
45a0b153b3
test_runner: add Date to the supported mock APIs 
signed-off-by: Lucas Santos <lhs.santoss@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/48638
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Erick Wendel <erick.workspace@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-10-23 11:23:12 +00:00
Geoffrey Booth
25576b5118
doc: explain how to disable navigator 
PR-URL: https://github.com/nodejs/node/pull/50310
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
 2023-10-22 22:24:27 +00:00
Juan José
c206b2a8a4
worker: handle detached MessagePort from a different context 
When `worker.moveMessagePortToContext` is used, the async handle
associated with the port, will be triggered more than needed (at least
one more time) and with null data. That can be avoided by simply
checking that the data is present and the port is not detached.

Fixes: https://github.com/nodejs/node/issues/49075
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: https://github.com/nodejs/node/pull/49150
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-10-22 21:20:52 +00:00
Aras Abbasi
a58ffad656
lib: improve performance of validateStringArray and validateBooleanArray 
PR-URL: https://github.com/nodejs/node/pull/49756
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
 2023-10-22 21:12:38 +00:00
Yagiz Nizipli
d370ed0cd8
test: set test-watch-mode-inspect as flaky 
PR-URL: https://github.com/nodejs/node/pull/50259
Refs: https://github.com/nodejs/node/issues/49933
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-22 20:10:41 +00:00
Robert Nagy
633642e156
stream: simplify prefinish 
PR-URL: https://github.com/nodejs/node/pull/50204
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
 2023-10-22 16:43:18 +00:00
Node.js GitHub Bot
76f59b4ca0
deps: update undici to 5.26.4 
PR-URL: https://github.com/nodejs/node/pull/50274
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-10-22 15:20:48 +00:00
Shi Pujin
7dc74a0451
doc: add loong64 info into platform list 
PR-URL: https://github.com/nodejs/node/pull/50086
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
 2023-10-22 10:07:13 +00:00
Richard Lau
0cec82277c
doc: update release process LTS step 
A recent refactor of `nodejs-latest-linker` has moved the mapping
between Node.js versions and codenames to a different file.

Refs: https://github.com/nodejs/nodejs-latest-linker/pull/12
PR-URL: https://github.com/nodejs/node/pull/50299
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-21 17:38:09 +00:00
Antoine du Hamel
745979cf39
Revert "test: set test-esm-loader-resolve-type as flaky" 
This reverts commit 2e4bb3c017bac7c0366cf977a92271b0242d4656.

PR-URL: https://github.com/nodejs/node/pull/50315
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-21 15:54:28 +00:00
Ulises Gascón
fc423db0aa
tools: drop support for osx notarization with gon 
Refs: https://github.com/nodejs/build/issues/3385#issuecomment-1729281269
PR-URL: https://github.com/nodejs/node/pull/50291
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-10-21 15:54:17 +00:00
Niya Shiyas
4f0a7ae09a test: replace forEach with for..of in test-http-perf_hooks.js 
PR-URL: https://github.com/nodejs/node/pull/49818
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-21 16:21:50 +02:00
Niya Shiyas
b084b26c44
test: replace forEach with for..of in test-net-isipv4.js 
PR-URL: https://github.com/nodejs/node/pull/49822
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
 2023-10-21 12:32:43 +00:00
Antoine du Hamel
c38ba67a0d
test: deflake test-esm-loader-resolve-type 
PR-URL: https://github.com/nodejs/node/pull/50273
Fixes: https://github.com/nodejs/node/issues/50040
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-10-21 09:25:11 +00:00
Niya Shiyas
63e9d0282d test: replace forEach with for..of in test-http2-server 
PR-URL: https://github.com/nodejs/node/pull/49819
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-21 07:01:01 +02:00
Niya Shiyas
fd562efcfe
test: replace forEach with for..of in test-http2-client-destroy.js 
PR-URL: https://github.com/nodejs/node/pull/49820
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-21 04:59:05 +00:00
Aras Abbasi
2e5ffe9fcf
util: remove internal mime fns from benchmarks 
PR-URL: https://github.com/nodejs/node/pull/50201
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-21 02:12:44 +00:00
Jungku Lee
506858bf13
fs: improve error performance for readSync 
PR-URL: https://github.com/nodejs/node/pull/50033
Refs: https://github.com/nodejs/performance/issues/106
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-10-21 02:00:00 +00:00
Node.js GitHub Bot
6ed8269f07 deps: update c-ares to 1.20.1 
PR-URL: https://github.com/nodejs/node/pull/50082
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-10-20 23:39:26 +00:00
Node.js GitHub Bot
581344f150 deps: update c-ares to 1.20.0 
Co-authored-by: Richard Lau <rlau@redhat.com>
PR-URL: https://github.com/nodejs/node/pull/50082
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
 2023-10-20 23:39:25 +00:00
Jungku Lee
fbd08ec4f3
fs: improve error performance for fsyncSync 
PR-URL: https://github.com/nodejs/node/pull/49880
Refs: https://github.com/nodejs/performance/issues/106
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-10-20 23:39:14 +00:00
CanadaHonk
c37cf1832c
fs: improve error performance for mkdirSync 
PR-URL: https://github.com/nodejs/node/pull/49847
Refs: https://github.com/nodejs/performance/issues/106
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
 2023-10-20 23:39:03 +00:00
Yagiz Nizipli
6678a09b59
test: update url web platform tests 
PR-URL: https://github.com/nodejs/node/pull/50264
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-20 21:57:33 +00:00
Yagiz Nizipli
05a7810a1d
lib: add navigator.userAgent 
PR-URL: https://github.com/nodejs/node/pull/50200
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Matthew Aitken <maitken033380023@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-20 20:22:48 +00:00
Filip Skokan
cd6b86bb5a
crypto: ensure valid point on elliptic curve in SubtleCrypto.importKey 
PR-URL: https://github.com/nodejs/node/pull/50234
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
 2023-10-20 16:25:42 +00:00
Geoffrey Booth
02926d3c6a
esm: detect ESM syntax in ambiguous JavaScript 
PR-URL: https://github.com/nodejs/node/pull/50096
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Guy Bedford <guybedford@gmail.com>
 2023-10-20 15:44:56 +00:00
Yagiz Nizipli
2d24518bfa
test: set test-emit-after-on-destroyed as flaky 
Ref: https://github.com/nodejs/node/issues/50245
PR-URL: https://github.com/nodejs/node/pull/50246
Refs: https://github.com/nodejs/node/issues/50245
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-10-20 15:36:06 +00:00
Yagiz Nizipli
35becbc9a9 test: set inspector async stack test as flaky 
https://github.com/nodejs/node/issues/50243
PR-URL: https://github.com/nodejs/node/pull/50244
Refs: https://github.com/nodejs/node/issues/50243
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-10-20 10:27:50 -04:00
StefanStojanovic
b4cc3e27c7 test: set test-worker-nearheaplimit-deadlock flaky 
PR-URL: https://github.com/nodejs/node/pull/50277
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-10-20 09:40:52 -04:00
Yagiz Nizipli
5ab70b3325 test: set test-cli-node-options as flaky 
PR-URL: https://github.com/nodejs/node/pull/50296
Refs: https://github.com/nodejs/node/issues/50295
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-10-20 09:28:36 -04:00
Michael Lumish
93c4efeb25
http2: allow streams to complete gracefully after goaway 
A detailed analysis of the cause of this bug is in my linked comment on
the corresponding issue. The primary fix is the new setImmediate call in
Http2Stream#_destroy, which prevents a re-entrant call into
Http2Session::SendPendingData when sending trailers after the
Http2Session has been shut down, allowing the trailer data to be flushed
properly before the socket is closed.

As a result of this change, writes can be initiated later in the
lifetime of the Http2Session. So, when a JSStreamSocket is used as the
underlying socket reference for an Http2Session, it needs to be able to
accept write calls after it is closed.

In addition, now that outgoing data can be flushed differently after a
session is closed, in two tests clients receive errors that they
previously did not receive. I believe the new errors are more correct,
so I changed the tests to match.

Fixes: https://github.com/nodejs/node/issues/42713
Refs: https://github.com/nodejs/node/issues/42713#issuecomment-1756140062
PR-URL: https://github.com/nodejs/node/pull/50202
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-10-20 13:28:18 +00:00
Luigi Pinca
0345ea5928
test: reduce the number of requests and parsers 
The maximum number of parsers in the free list is set to 1000. However
the test does not need to use this maximum. Reduce it to 50.

Refs: https://github.com/nodejs/node/pull/50228#issuecomment-1768293624
PR-URL: https://github.com/nodejs/node/pull/50240
Fixes: https://github.com/nodejs/node/issues/49564
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-20 12:56:44 +00:00
Richard Lau
8f3146ea62
doc: fix release process table of contents 
The table of contents for the release process still references a
deleted section. Remove that reference, and renumber the following
table of contents entries so that they link through to the correct
sections.

PR-URL: https://github.com/nodejs/node/pull/50216
Refs: https://github.com/nodejs/node/pull/45858
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Rafael Gonzaga <rafael.nunu@hotmail.com>
 2023-10-20 11:27:27 +00:00
Yagiz Nizipli
eed33c9dea
test: set crypto-timing test as flaky 
PR-URL: https://github.com/nodejs/node/pull/50232
Refs: https://github.com/nodejs/node/issues/38226
Reviewed-By: Ruy Adorno <ruyadorno@google.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-10-20 02:15:13 +00:00
Rich Trott
b30acb7fd1
meta: move Trott to TSC regular member 
At the current time, I'm not able to give Node.js the time and attention
it needs and deserves from a voting TSC member. I'm proud of the work
and efforts I've made as a TSC voting member, and I want to leave before
I'm less happy with my efforts. Thanks for all the trust and good will
over the years.

PR-URL: https://github.com/nodejs/node/pull/50297
Reviewed-By: Tierney Cyren <hello@bnb.im>
Reviewed-By: Richard Lau <rlau@redhat.com>
 2023-10-19 17:40:28 +00:00
Yagiz Nizipli
f9c290f0e9
test: set test-structuredclone-* as flaky 
PR-URL: https://github.com/nodejs/node/pull/50261
Refs: https://github.com/nodejs/node/issues/50260
Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-19 16:03:49 +00:00
Tobias Nießen
e45e73b335
buffer: remove unnecessary assignment in fromString 
The assignment to the encoding variable has no effect.

Refs: https://github.com/nodejs/node/pull/29217
PR-URL: https://github.com/nodejs/node/pull/50199
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-19 11:47:45 +00:00
Antoine du Hamel
765339a32c
test: deflake test-loaders-workers-spawned 
PR-URL: https://github.com/nodejs/node/pull/50251
Fixes: https://github.com/nodejs/node/issues/50247
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
 2023-10-19 10:44:46 +02:00
Jithil P Ponnan
a8af24b59c
test: improve code coverage of diagnostics_channel 
test: improve code coverage of diagnostics_channel
PR-URL: https://github.com/nodejs/node/pull/50053
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
 2023-10-19 06:37:09 +00:00
Alex Yang
c016397276
doc: update api stream.compose 
PR-URL: https://github.com/nodejs/node/pull/50206
Refs: https://github.com/nodejs/node/pull/50187/files#r1361215879
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-19 01:00:05 +00:00
Yagiz Nizipli
2e4bb3c017
test: set test-esm-loader-resolve-type as flaky 
Ref: https://github.com/nodejs/node/issues/50040
PR-URL: https://github.com/nodejs/node/pull/50226
Refs: https://github.com/nodejs/node/issues/50040
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
 2023-10-19 00:15:28 +00:00
Yagiz Nizipli
e0bbe56630
test: set inspector async hook test as flaky 
Ref: https://github.com/nodejs/node/issues/50222
PR-URL: https://github.com/nodejs/node/pull/50252
Refs: https://github.com/nodejs/node/issues/50222
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-10-18 22:19:39 +00:00
Tim Perry
dc04c5ed9a
tls: reduce TLS 'close' event listener warnings 
Without this, some heavy usage of TLS sockets can result in
MaxListenersExceededWarning firing, from the 'this.on('close', ...)'
line here.

These appear to come from reinitializeHandle, which calls _wrapHandle
repeatedly on the same socket instance.

PR-URL: https://github.com/nodejs/node/pull/50136
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
 2023-10-18 19:44:40 +00:00
Abdirahim Musse
286fdafe9d test: skip test-benchmark-os.js on IBM i 
PR-URL: https://github.com/nodejs/node/pull/50208
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michael Dawson <midawson@redhat.com>
 2023-10-18 15:33:56 -04:00
Vinicius Lourenço
340b9a827b
doc: add ReflectConstruct to known perf issues 
PR-URL: https://github.com/nodejs/node/pull/50111
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
 2023-10-18 19:28:08 +00:00
Yagiz Nizipli
b3313bf03f
test: set parallel http server test as flaky 
Ref: https://github.com/nodejs/node/issues/43465
PR-URL: https://github.com/nodejs/node/pull/50227
Refs: https://github.com/nodejs/node/issues/43465
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
 2023-10-18 18:13:04 +00:00
Yagiz Nizipli
1a5db6f173 fs: improve error performance of realpathSync 
PR-URL: https://github.com/nodejs/node/pull/49962
Refs: https://github.com/nodejs/performance/issues/106
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-18 15:56:27 +00:00
Yagiz Nizipli
5f0276d7a0 fs: improve error performance of lchownSync 
PR-URL: https://github.com/nodejs/node/pull/49962
Refs: https://github.com/nodejs/performance/issues/106
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Stephen Belanger <admin@stephenbelanger.com>
Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br>
 2023-10-18 15:56:26 +00:00