52987 Commits

Author SHA1 Message Date
k0kubun
d96483de72 mjit_worker.c: return more appropriate result
of copy job. When job is being stopped but job is actually finished,
returning FALSE could be a little confusing from the function name.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65301 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-22 09:53:00 +00:00
k0kubun
89293c4ba1 mjit_worker.c: check appropriate flag to stop
This was not intentional in r65299.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65300 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-22 09:48:35 +00:00
k0kubun
821ff80c0c mjit_worker.c: make sure copy job wait is unblocked
by stop_worker(). Previously copy_cache_from_main_thread() might loop forever
even with stop_worker() is being called from ruby_cleanup().

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65299 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-22 09:40:44 +00:00
shyouhei
7fbf01348b .travis.yml: give up -O0
This configuration timed out.
https://travis-ci.org/ruby/ruby/jobs/444523912

Try speed things up.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65298 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-22 03:59:48 +00:00
k0kubun
93e780e03b test_thread.rb: another temporary skip for MJIT
to make trunk-mjit-wait CI green for now. I'll take a look at this
later.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65297 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-22 03:31:13 +00:00
nobu
8747974d4b time.c: optional arguments of Time::TM#initialize
* time.c (tm_initialize): arguments other than year are optional
  now as Time.new.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65296 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-22 01:25:29 +00:00
hsbt
3dc960deab Merge stringio.gemspec from github repository.
It fixed the wrong paths of libraries.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65295 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-22 00:32:16 +00:00
hsbt
615ac35934 Merge rubygems master branch from github.com/rubygems/rubygems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65294 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-22 00:27:02 +00:00
nobu
ff31b35f6a test_time_tz.rb: refactor dummy TZ tests and add another timezone
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65293 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 23:53:39 +00:00
k0kubun
c657e57343 skip 2 tests for MJIT for now
These tests seem to be broken by r65275.
Let me skip this to confirm if other things are fine or not.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65292 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 23:53:24 +00:00
k0kubun
e91be25644 revert revert of r65285
because CI was actually hitting another one.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65291 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 23:20:32 +00:00
k0kubun
cfa7e2707e revert r65285
because it didn't work. Partially leaving "sometimes fail" tests.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65290 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 23:07:18 +00:00
naruse
879b42b043 check VLIW case
If maximum_operations_per_instruction != 1, it is VLIW.
But there seems no need to support such architecture now.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65289 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 20:01:22 +00:00
stomar
281d45ab0a lib/net/http.rb: [DOC] fix typos
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65288 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 20:00:46 +00:00
naruse
448a014d42 initialize is_stmt with default_is_stmt
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65287 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 16:42:23 +00:00
naruse
6018bc5e73 Use inline function with stable code instead of macro
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65286 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 16:37:24 +00:00
k0kubun
e6202c41b5 try to remove some test skips for MJIT
Eric Wong made some effort to keep compatibility around fd with MJIT.
Also I'm hoping r65279 (and r65280) eliminates major MJIT bugs, so I
want to start solely testing MJIT. Other test skips branched by MJIT
enablement seemed reasonable to me.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65285 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 15:54:50 +00:00
k0kubun
84d747c6d9 NEWS: note about --disable-mjit-support [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65284 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 15:41:00 +00:00
aycabta
2f7880e18a Improve docs of Proc / Method
* proc.c: Add descriptions and code examples.

[ruby-core:85600] [Bug #14483]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65283 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 15:33:30 +00:00
svn
9c729c1ec8 * 2018-10-22
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65282 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 15:29:02 +00:00
k0kubun
2c8b8b3fd4 NEWS: prefer advertising --jit option [ci skip]
In addition to `--enable=jit` and `--enable-jit`, we're going to ship
`--jit` as a short hand of it in Ruby 2.6.0.

That's because both --enable=jit and --enable-jit are super hard to
type everytime on command line, and I want make it easier to use so
that many people use it. First of all, `--enable=jit` is accidentally
added for consistency with `--disable=jit` and it's not added for human.

As it's a short hand, once JIT became enabled by default, the `--jit`
option would be removed after some deprecation warning period and only
`--enable=jit`/`--disable=jit` will survive. That being said, I still
think having `--jit` as a temporary short hand is valuable for the above
reasons.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65281 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 15:29:01 +00:00
k0kubun
a35eb0cc7d mjit.c: remove wrongly-committed debug code
mistake in r65279.

=== Optcarrot Benchmark ===
$ benchmark-driver benchmark.yml --rbenv 'before::before --disable-gems --jit;after::after --disable-gems --jit' -v --repeat-count 24
before: ruby 2.6.0dev (2018-10-21 trunk 65277) +JIT [x86_64-linux]
after: ruby 2.6.0dev (2018-10-21 trunk 65279) +JIT [x86_64-linux]
last_commit=mjit.c: remove wrongly-committed debug code
Calculating -------------------------------------
                             before       after
Optcarrot Lan_Master.nes     85.008      86.078 fps

Comparison:
             Optcarrot Lan_Master.nes
                   after:        86.1 fps
                  before:        85.0 fps - 1.01x  slower

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65280 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 14:30:18 +00:00
k0kubun
13df05acfa mjit.c: copy call cache values to MJIT worker
same as r65275 but for call cache.

=== Optcarrot Benchmark ===
$ benchmark-driver benchmark.yml --rbenv 'before::before --disable-gems --jit;after::after --disable-gems --jit' -v --repeat-count 24
before: ruby 2.6.0dev (2018-10-21 trunk 65277) +JIT [x86_64-linux]
after: ruby 2.6.0dev (2018-10-21 trunk 65277) +JIT [x86_64-linux]
last_commit=mjit.c: copy call cache values to MJIT worker
Calculating -------------------------------------
                             before       after
Optcarrot Lan_Master.nes     85.372      85.359 fps

Comparison:
             Optcarrot Lan_Master.nes
                  before:        85.4 fps
                   after:        85.4 fps - 1.00x  slower

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65279 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 14:23:24 +00:00
stomar
bca2cdcc0b lib/mutex_m.rb: fix example code in documentation
* lib/mutex_m.rb: [DOC] fix invalid example code to make it
  syntax highlighted.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65278 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 14:02:00 +00:00
k0kubun
27295e94f2 vm_core.h: fix typo [ci skip]
The comment didn't make sense. As it's allocated with
`ZALLOC_N(struct rb_call_cache, body->ci_size + body->ci_kw_size)`,
it's very likely to be forgotten to press shift key on US keyboard.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65277 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 13:45:36 +00:00
k0kubun
480eccbb35 _mjit_compile_send.erb: don't split send_guard
to another file, because it's no longer shared. It was created when
attr_reader was inlined but it's no longer included.

common.mk: ditto

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65276 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 13:37:13 +00:00
k0kubun
1b5aa4f516 mjit.c: copy inline cache values to MJIT worker
on VM_CHECK_INTS. Letting MJIT worker directly see inline cache which
may be being updated could result in inconsistent IC index and serial.

mjit_worker.c: request the copy job after dequeue, and receive the
result synchronously.

tool/ruby_vm/views/_mjit_compile_ivar.erb: use the copied IC

mjit_compile.c: change the interface to pass is_entries
mjit.h: ditto

=== Optcarrot Benchmark ===
Thankfully this didn't have major performance regression.

$ benchmark-driver benchmark.yml --rbenv 'before::before --disable-gems --jit;after::after --disable-gems --jit' -v --repeat-count 24
before: ruby 2.6.0dev (2018-10-21 trunk 65263) +JIT [x86_64-linux]
after: ruby 2.6.0dev (2018-10-21 trunk 65263) +JIT [x86_64-linux]
last_commit=mjit.c: copy inline cache values to MJIT worker
Calculating -------------------------------------
                             before       after
Optcarrot Lan_Master.nes     85.421      85.454 fps

Comparison:
             Optcarrot Lan_Master.nes
                   after:        85.5 fps
                  before:        85.4 fps - 1.00x  slower

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65275 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 13:21:28 +00:00
naruse
e01c9c743f fix sign of integer variable
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65272 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 10:46:56 +00:00
aycabta
d67b903519 Improve doc of yield_self
* object.c: Add code samples for yield_self.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65271 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 07:15:44 +00:00
aycabta
bb6b273f3d Add missing info for Mutex_m to the doc [Bug #13598]
* lib/mutex_m.rb: The #initialize method in a class that includes
  Mutex_m needs calling #super.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65270 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 07:04:20 +00:00
aycabta
fdbc8eed42 Improve doc of Regexp about "ignore case" behavior [Misc #10836]
* doc/regexp.rdoc: RDoc for "ignore case" behavior

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65269 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 06:42:53 +00:00
nobu
a87e4d9208 --excludes option must be in TEST_ALL_TESTOPTS
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65268 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 03:52:20 +00:00
nobu
741066fc2a Quote $(TESTSDIR)
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65267 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 03:42:46 +00:00
svn
1c8ddda933 * properties.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65266 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 03:38:53 +00:00
nobu
bf26f847fa Exclude CI platform specific failures by --excludes option
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65265 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 03:38:52 +00:00
ko1
543acfabdc fix a warning message.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65264 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 02:38:26 +00:00
k0kubun
40d070843d skip tests broken with OpenSSL 1.1.1 on Travis osx
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65263 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 02:28:43 +00:00
k0kubun
94792dbbc4 appveyor.yml: workaround wrong command line escape
backslash in %APPVEYOR_BUILD_FOLDER% is somehow dropped somewhere
when being passed to test runner via mingw32-make.

Anyway we know the relative path to the project directory, so we can
specify that with slash.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65262 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 02:18:39 +00:00
k0kubun
7fe170442b .travis.yml: mspec -j is unstable
https://travis-ci.org/ruby/ruby/jobs/444232677

Instead of that, add -fs to know problematic test case when failed.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65261 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 01:27:43 +00:00
k0kubun
fd8275d083 .travis.yml: use --job-status=replace
-v is too long, and "--color=never --job-status=normal" is too verbose.
Trying --job-status=replace to make Travis log easier to read.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65260 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 01:25:20 +00:00
k0kubun
f5bf1a32d0 appveyor.yml: fix wrong spec directory
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65259 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 00:31:46 +00:00
k0kubun
90369a8325 .travis.yml: debug problematic test case on osx
osx build is stucking somewhere. We want to debug that.
https://travis-ci.org/ruby/ruby/jobs/444059226

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65258 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 00:18:32 +00:00
naruse
ec91ea5c16 check version of .debug_info
and refactor related code.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65257 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 00:08:02 +00:00
naruse
69e328b532 Skip dwarf if its version is not supported
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65256 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-21 00:07:53 +00:00
k0kubun
e77fdcd81d appveyor.yml: don't run win32ole with -j
since it lets worker crash
https://ci.appveyor.com/project/ruby/ruby/builds/19659321/job/swnu2b5yj960t9gr

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65255 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-20 23:58:02 +00:00
nobu
3a9c427908 lldb_cruby.py: T_COMPLEX support [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65254 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-20 17:19:37 +00:00
kazu
80220db346 NEWS: Fix keywords [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65253 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-20 15:00:02 +00:00
svn
e705074898 * 2018-10-21
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65252 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-20 15:00:01 +00:00
kazu
45172a7b17 NEWS: Fix ,s [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65251 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-20 15:00:00 +00:00
suke
2afc2a0581 Merge branch 'modify_test_win32ole' into trunk
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65250 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-20 14:34:30 +00:00