52987 Commits

Author SHA1 Message Date
k0kubun
091c04df53 revert r65401
Because it does break Linux CI like:
https://gist.github.com/ko1/2c561f9185492f339cf7a763ea219e79

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65402 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-28 01:19:30 +00:00
suke
b343a583af remove rescue block when win32ole is required
* spec/ruby/library/win32ole/fixtures/classes.rb: remove rescue block
  because this file is required on Windows only.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65401 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-28 01:08:42 +00:00
suke
5477d297ec use Scripting.Dictionary instead of InternetExplorer.Application
* spec/ruby/library/win32ole/win32ole/ole_func_methods_spec.rb: use
  Scripting.Dictionary. InternetExplorer.Application is not available on
  some environment. Thanks to MSP-Greg (Greg L).

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65400 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-28 01:03:49 +00:00
suke
33a8b277dc use Scripting.Dictionary instead of InternetExplorer.Application.
* spec/ruby/library/win32ole/invoke_spec.rb: use Scripting.Dictionary
  instead of InternetExplorer.Application. InternetExplorer.Application
  is not available on some environment. Thanks to MSP-Greg (Greg L).

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65399 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 23:37:58 +00:00
suke
d6a9603eff use Scripting.Dictionary instead of InternetExplorer.Application for
_getproperty spec.

* spec/ruby/library/win32ole/_getproperty_spec.rb: use
  Scripting.Dictionary. InternetExplorer.Application is not available on
  some environment. (Thanks to MSP-Greg (Greg L))

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65398 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 23:21:29 +00:00
naruse
5eab7d7d55 fix test
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65397 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 23:15:43 +00:00
naruse
7594a8df75 fix error message and backtrace order
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65396 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 23:13:34 +00:00
suke
35ca97e981 add WIN32OLESpecs::MSXML_AVAILABLE
* spec/ruby/library/win32ole/fixtures/classes.rb: add
WIN32OLESpecs::MSXML_AVAILABLE

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65395 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 22:50:08 +00:00
svn
1064376b86 * 2018-10-28
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65394 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 21:45:32 +00:00
naruse
48af6fd544 Print exception's cause like Java
Print `cause` of the exception if the exception is not caught and printed
its backtraces and error message [Feature #8257]

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65393 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 21:45:30 +00:00
k0kubun
1346e39ce6 spec/../shared/exit.rb: move the mingw guard to here
from terminate_spec.rb, as suggested here:
c7220bd3de (commitcomment-31068714)

to guard other inclusions.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65392 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 14:06:44 +00:00
k0kubun
090e2130d3 revert r65389 and r64993
and move retry logic to internal method

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65391 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 13:57:23 +00:00
eregon
cb9f2066b5 Run specs on latest Ruby 2.3, which includes taint fixes
* The 2.3 alias in RVM seems to resolve to 2.3.7.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65390 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 11:42:21 +00:00
k0kubun
a7f0cbe9c8 ole_func_methods_spec.rb: apply r64993 retry
to this spec as well, since the same issue was reproduced here
https://ci.appveyor.com/project/ruby/ruby/builds/19842006/job/y35ae6bquf4t3x30

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65389 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 10:49:56 +00:00
eregon
3e6337b88b Update to ruby/spec@8b743a3
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65388 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 10:48:40 +00:00
eregon
ecc707e233 Update to ruby/mspec@4729971
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65387 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 10:48:09 +00:00
k0kubun
970410c63c .travis.yml: investigate silent death of mspec
It looks like mspec worker may immediately die on Linux as well.
https://travis-ci.org/ruby/ruby/jobs/447018758

Dropping -j and add -fs to know which test dies.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65386 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 09:57:30 +00:00
kazu
4365e64005 bootstraptest/test_insns.rb: test newhashfromarray
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65385 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 08:17:01 +00:00
knu
b16d73ae0c Update the example of local variable shadowing
I came up with this snippet when we were trying to convince Matz.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65384 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 07:22:38 +00:00
k0kubun
35e3e13ce7 test_io.rb: skip busy wait test again
which I tried to avoid skipping this in r65311, but the test seems not
working under some high load of ci.rvm.jp.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65383 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-27 05:14:46 +00:00
stomar
8f0eb44d93 string.c: improve docs for String#strip and related
* string.c: [DOC] improve docs for String#{strip,lstrip,rstrip}{,!}:
  small clarification, avoid referring to the receiver as `str'
  (does not appear in the call-seq of the generated HTML docs),
  enable links for cross-references, simplify rdoc.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65382 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 20:30:09 +00:00
svn
ab99fd06ca * 2018-10-27
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65381 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 17:08:33 +00:00
nobu
b0546f1cc6 Do not :stopdoc: entire classes/modules
It disables cross-references to the classes/modules, even if those
are defined in other places.  I suspect this is not an intentional
behavior, however make a workaround for the time being.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65380 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 17:08:30 +00:00
stomar
f889eba1d4 proc.c: [DOC] improve docs for {Method,Proc}#===
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65379 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 12:23:25 +00:00
stomar
96353b97a5 proc.c: [DOC] fix grammar in doc for Method#to_s
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65378 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 12:21:22 +00:00
stomar
905be736f7 object.c: [DOC] fix typos in doc for yield_self
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65377 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 12:19:04 +00:00
stomar
61cccab436 NEWS: fix typos
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65376 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 12:16:25 +00:00
k0kubun
0c289a7f22 appveyor.yml: run second half of vs with -v
because it may silently die like
https://ci.appveyor.com/project/ruby/ruby/builds/19813015/job/a99c4hrs69g4iorg
and we can't know which test was bad.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65375 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 08:34:42 +00:00
nobu
300ac6c573 Fix a condition and just call rb_fstring [Feature #15251]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65374 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 06:41:34 +00:00
svn
ea9961f9be * expand tabs.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65373 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 06:18:30 +00:00
nobu
81c849172d Simplify conditions [Feature #15251]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65372 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 06:18:28 +00:00
normal
1e83e15ab5 hash.c: aset deduplicates un-tainted string
We revisit [Bug #9188] since st.c is much improved since then,
and benchmarks against so_k_nucleotide seem to indicate little
or no performance change compared to before.

[ruby-core:89555] [Feature #15251]

From: Anmol Chopra <chopraanmol1@gmail.com>

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65371 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 05:32:47 +00:00
nobu
7cc758f7a8 Indent as a code block [ci skip]
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65370 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 04:46:24 +00:00
mame
c9d720b873 parse.y: remove "shadowing outer local variable" warning
You can now write the following without warning.

    user = User.all.find {|user| cond(user) }

Fixes [Feature #12490].
A patch from Soutaro Matsumoto <matsumoto@soutaro.com>.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65369 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 03:10:02 +00:00
mame
b171d92046 Revert "parse.y: remove "shadowing outer local variable" warning"
I forgot to add the copyright of the patch...

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65368 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 03:08:10 +00:00
mame
7f69d4e41f parse.y: remove "shadowing outer local variable" warning
You can now write the following without warning.

  user = User.all.find {|user| cond(user) }

Fixes [Feature #12490].

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65367 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 02:54:01 +00:00
svn
df38879ae6 * 2018-10-26
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65366 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 01:47:14 +00:00
nobu
e71ca6cdcf Update for tzdata-2018f
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65365 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-26 01:47:09 +00:00
hsbt
a509de06bc Added initialization task for default gems.
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65364 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-25 10:16:28 +00:00
k0kubun
2160c4dead wercker.yml: skip webrick for test-mjit-wait for now
as failing
https://app.wercker.com/ruby/ruby/runs/test-mjit-wait/5bd092a89b1e440006d5780d?step=5bd092e3591ca80007258400
now and it needs some fix.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65363 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-25 03:25:19 +00:00
ko1
85173be41f add new counter about GC.
* debug_counter.h: add `gc_major_oldmalloc`.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65362 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-25 02:23:58 +00:00
kazu
b2b8b4a16e Fix a typo
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65361 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-25 02:07:47 +00:00
nobu
4c875b6e66 time.c: benchmark recovery
* time.c (time_localtime): check if `vtm.zone` is a simple zone
  name string before trying to call the conversion method.  since
  r64952, `Time.getlocal` on UTC time has lost the performance
  about 45%, due to this call.  the performance is about 90% of
  r64951 by avoiding it.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65360 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-25 00:36:23 +00:00
ko1
f8dbff557a add new debug_counters for GC.
* debug_counter.h: add new debug counters to count GC.


git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65359 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-24 22:17:03 +00:00
k0kubun
0fbc28dec5 wercker.yml: rearrange test split times
test-all2 is taking much longer time than test-all1 now.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65358 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-24 15:49:03 +00:00
svn
d82a7612de * 2018-10-25
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65357 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-24 15:41:15 +00:00
k0kubun
97f3e426a1 _mjit_compile_ivar.erb: cancel on undefined ivar
I assumed somehow this check was not needed, but it did need.
By canceling this instead of just warning here, we didn't lose the
current performance so much.

test_jit.rb: test the case that reproduces SEGV by that.

TestGemStreamUI.rb: delete. This test on --jit-wait is fixed.

=== Optcarrot Benchmark ===

$ benchmark-driver benchmark.yml --rbenv 'before::before --disable-gems --jit;after::after --disable-gems --jit' -v --repeat-count 24
before: ruby 2.6.0dev (2018-10-24 trunk 65355) +JIT [x86_64-linux]
after: ruby 2.6.0dev (2018-10-24 trunk 65355) +JIT [x86_64-linux]
last_commit=_mjit_compile_ivar.erb: cancel on undefined ivar
Calculating -------------------------------------
                             before       after
Optcarrot Lan_Master.nes     85.344      84.849 fps

Comparison:
             Optcarrot Lan_Master.nes
                  before:        85.3 fps
                   after:        84.8 fps - 1.01x  slower

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65356 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-24 15:41:14 +00:00
k0kubun
593b58534f test_jit.rb: test newhashfromarray
git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65355 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-24 14:24:34 +00:00
k0kubun
f84c318420 revert r65353 [ci skip]
As Wercker is managing workflow by GUI, the commit had no impact for
behavior... I already fixed the workflow on GUI. Let revert that to
change it back to natural order.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65354 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-24 12:19:39 +00:00
k0kubun
beec400d9e wercker.yml: run slower job first
to reduce time taken for finishing all jobs.

git-svn-id: svn+ssh://ci.ruby-lang.org/ruby/trunk@65353 b2dd03c8-39d4-4d8f-98ff-823fe69b080e
2018-10-24 12:14:26 +00:00